added className as option to callAll#35
Open
bheisen wants to merge 1 commit into
Open
Conversation
Contributor
|
I have tested this approach with the examples-2 and even with examples-3 added on my test branch. Both fail with the same error. |
benjamin-joham
suggested changes
Feb 8, 2021
benjamin-joham
left a comment
benjamin-joham
left a comment
Contributor
There was a problem hiding this comment.
The changes also have to be built.
I want to have a proper setup working before we merge that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in the pull request:
Changed API of
callAllfunction to support provisioning of an explicitclassNamecloses #34