Skip to content

Replace hasattr(data, "__len__") duck typing with ndim-based collection detection - #1414

Merged
rly merged 10 commits into
devfrom
remove_duck_typing_for_array_detection
Mar 10, 2026
Merged

Replace hasattr(data, "__len__") duck typing with ndim-based collection detection#1414
rly merged 10 commits into
devfrom
remove_duck_typing_for_array_detection

Merge remote-tracking branch 'refs/remotes/origin/remove_duck_typing_…

ab39a9e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 10, 2026 in 0s

93.08% (+0.02%) compared to 078512c

View this Pull Request on Codecov

93.08% (+0.02%) compared to 078512c

Details

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.08%. Comparing base (078512c) to head (ab39a9e).

Files with missing lines Patch % Lines
src/hdmf/build/objectmapper.py 75.00% 0 Missing and 1 partial ⚠️
src/hdmf/common/table.py 83.33% 0 Missing and 1 partial ⚠️
src/hdmf/validate/validator.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1414      +/-   ##
==========================================
+ Coverage   93.06%   93.08%   +0.02%     
==========================================
  Files          41       41              
  Lines        9989    10007      +18     
  Branches     2054     2060       +6     
==========================================
+ Hits         9296     9315      +19     
+ Misses        417      416       -1     
  Partials      276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.