Conversation
andreasabel
approved these changes
May 28, 2026
Member
There was a problem hiding this comment.
LGTM. lukko does not seem to get upgraded to GHC 9.14, so it makes sense to drop it.
| base-compat >= 0.12.2 | ||
|
|
||
| constraint-set no-lukko | ||
| constraints: hackage-security -lukko |
Member
There was a problem hiding this comment.
That was probably the wrong way round: since lukko was off by default, this constraint-set did not test anything (I suppose the intention was to actually test lukko). This explains why CI on GHC 9.14 did not fail despite lukko not being available.
Member
|
@Bodigrim Do you have rights to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A year ago we stopped using
lukkopackage by default and guarded it by a Cabal flag. No one complained and I never heard of anyone forcing the Cabal flag to uselukkoinstead ofbase. I think it's time we clean it up entirely.