Skip to content

feat: ensure Dockerfiles being up-to-date - #162

Closed
develop7 wants to merge 1 commit into
haskell:masterfrom
develop7:push-lnzuuwkzwukz
Closed

develop7 wants to merge 1 commit into
haskell:masterfrom
develop7:push-lnzuuwkzwukz

Conversation

@develop7

Copy link
Copy Markdown
Collaborator

Introduces linting workflow that makes sure generated Dockerfiles are up-to-date

@develop7
develop7 force-pushed the push-lnzuuwkzwukz branch 11 times, most recently from 761e5f6 to 92d7a5c Compare October 21, 2025 12:25
@develop7
develop7 marked this pull request as ready for review October 21, 2025 12:26
@develop7
develop7 requested review from chreekat and jhrcek October 21, 2025 12:27
@develop7
develop7 force-pushed the push-lnzuuwkzwukz branch 4 times, most recently from 8cce804 to f575b9a Compare October 24, 2025 14:03
@chreekat

Copy link
Copy Markdown

Awesome!

I'm curious, why do you pull the generator binary from a different workflow, rather than just use stack run in the same checkout that's being tested? .stack-work is being cached, so it's hard to say which choice would be faster. Plus, using the same checkout for testing means that it's easy to keep the generator and the dockerfiles in sync, doesn't it?

@develop7

develop7 commented Nov 9, 2025 •

Copy link
Copy Markdown
Collaborator Author

@chreekat because I seemingly cannot share artifacts between workflows and generator's cold build path takes too much time, which becomes a sudden obstacle for every innocent GHC upgrade PR by increasing build time to tens of minutes or so. Also artifacts have an expiry date, as well as actions cache items, so regular contributors would hit the "wait for the build the whole generator" wall every so often and we probably don't want that.

@chreekat

chreekat commented Nov 14, 2025 •

Copy link
Copy Markdown

Hm.. then I wonder if it would be better to make "build generator" and "lint Dockerfiles" separate jobs in the same workflow, rather than putting them in two separate workflows. It actually makes sense to me that workflow files should be based on events like "pr is opened" rather than having multiple workflows trigger for the same event.

The problem with pulling generator from a totally different place is that you're guaranteed to have incorrect results if you change generator in a PR and expect to see its changes reflected in the Dockerfiles, aren't you?

@develop7

develop7 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

superseded by #181

@develop7 develop7 closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants