Skip to content

More tests for asm-options, ld-options, cpp-options#11711

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
zlonast:zlonast/ghc-options-tests
May 16, 2026
Merged

More tests for asm-options, ld-options, cpp-options#11711
mergify[bot] merged 1 commit into
haskell:masterfrom
zlonast:zlonast/ghc-options-tests

Conversation

@zlonast
Copy link
Copy Markdown
Collaborator

@zlonast zlonast commented Apr 7, 2026

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@zlonast zlonast force-pushed the zlonast/ghc-options-tests branch 2 times, most recently from 975e121 to 2d15da3 Compare April 7, 2026 15:40
@zlonast zlonast changed the title More tests for asm-options, ld-options, -pgmc, cpp-options More tests for asm-options, ld-options, cpp-options Apr 7, 2026
@zlonast zlonast mentioned this pull request Apr 7, 2026
Open
6 tasks
@zlonast zlonast force-pushed the zlonast/ghc-options-tests branch from 2d15da3 to 45debf7 Compare April 7, 2026 18:38
@zlonast
Copy link
Copy Markdown
Collaborator Author

zlonast commented Apr 8, 2026

We haven't had any tests for these options before, and we'd like to simplify the situation in this area.

@zlonast zlonast force-pushed the zlonast/ghc-options-tests branch 4 times, most recently from d95104c to 6f357cb Compare April 25, 2026 07:39
ulysses4ever
ulysses4ever approved these changes May 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a slow turnaround here... And thanks for working on better test coverage!

Having Readme in package tests is a bit unconventional I think but that's all right. More often the test script would have a comment explaining its purpose.

@zlonast zlonast force-pushed the zlonast/ghc-options-tests branch from 6f357cb to 87133a4 Compare May 9, 2026 10:34
@zlonast zlonast mentioned this pull request May 13, 2026
Open
4 tasks
Mikolaj
Mikolaj reviewed May 14, 2026
View reviewed changes
Comment thread cabal-testsuite/PackageTests/FFI/ForeignOptsLd/Main.hs Outdated
Mikolaj
Mikolaj approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zlonast zlonast force-pushed the zlonast/ghc-options-tests branch from 87133a4 to 1bdef95 Compare May 14, 2026 18:24
@zlonast zlonast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels May 14, 2026
@zlonast zlonast force-pushed the zlonast/ghc-options-tests branch from 1bdef95 to fde977e Compare May 14, 2026 18:56
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label May 14, 2026
@zlonast zlonast force-pushed the zlonast/ghc-options-tests branch from fde977e to b7d97c3 Compare May 14, 2026 21:42
@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels May 16, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 16, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 2 hours 13 minutes 17 seconds in the queue, including 2 hours 2 minutes 58 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify Bot added a commit that referenced this pull request May 16, 2026
@mergify
Merge of #11711
63a8e91
@mergify mergify Bot mentioned this pull request May 16, 2026
Closed
86 tasks
mergify Bot added a commit that referenced this pull request May 16, 2026
@mergify
Merge of #11711
ced168d
mergify Bot added a commit that referenced this pull request May 16, 2026
@mergify
Merge of #11711
0ad2147
@mergify mergify Bot merged commit 700436f into haskell:master May 16, 2026
136 checks passed
@mergify mergify Bot removed the queued label May 16, 2026
@zlonast zlonast deleted the zlonast/ghc-options-tests branch May 18, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikolaj Mikolaj Mikolaj approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees

No one assigned

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zlonast @Mikolaj @ulysses4ever