Repository navigation
fix: give the drag handle and the sub-navigation checkbox accessible names - #10
Merged
Merged
Conversation
…names The drag handle was an icon-only button with no name, announced as just "button". It is now labelled like Filament's own handles — Filament's translated "Move" plus the view's name. The sub-navigation checkbox had only a title, identical in every row; its aria-label now names the view. Both reuse existing translations, so no new strings.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The accessibility changes are covered by tests, with no blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Adds accessible, view-specific names to saved-view drag handles and sub-navigation checkboxes.
Changes:
- Reuses localized labels for both controls.
- Adds tests for accessible labels and locale resolution.
| File | Summary |
|---|---|
tests/Feature/AccessibleControlsTest.php |
Verifies labels and translation resolution. |
resources/views/livewire/saved-views-control.blade.php |
Adds accessible names to manager controls. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two controls in each manager row had no usable accessible name:
<button>with no label — a screen reader announced it as just "button", once per view. It now getsaria-label="Move <view name>", the way Filament labels its own drag handles (its translated "Move" in the builder, "Reorder column" + the column name in the column manager).title, identical in every row ("Show in the page menu"). Itsaria-labelnow names the view: "Show in the page menu: Verified users".No new strings: the handle reuses Filament's translated
filament-forms::components.builder.actions.reorder.label("Move", in 63 of the 64 locales;hifalls back to English exactly like Filament's own builder), the checkbox reuses the package'ssubmenu_visible.Test plan
AccessibleControlsTest: both labels are in the template; the borrowed Filament key resolves in every locale the package shipsMove Verified users/Show in the page menu: Verified users, andPrzesuń …/Pokaż w menu strony: …withAPP_LOCALE=plcomposer test(179 passed),phpstan,pint --test,rector --dry-run