Skip to content

feat: translate the comments into every locale Filament ships - #7

Merged
webard merged 1 commit into
2.xfrom
feat/translations
Sep 25, 2026
Merged

webard merged 1 commit into
2.xfrom
feat/translations

Conversation

@webard

@webard webard commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds resources/lang/{locale}/comments.php for the 62 locales Filament ships that were missing, so all 64 are now covered, en and pl included. There are 18 keys per locale.
  • Wording follows each language's own Filament translations ("delete", "submit", "link", "copy") and matches Filament's formal or informal "you".
  • TranslationsTest now also checks:
    • no value is left in English (there is an allowlist, but it is empty);
    • every locale Filament ships has a file;
    • Filament's locale directory exists, so the coverage check can't pass on an empty dataset.
  • The README lists the locales.

Worth a native speaker's look

  • lus (Mizo): "comment" and "quote" have no Filament equivalent, so these words are our own choice.
  • ckb / ku (Sorani): the word for "quote" is our own choice.
  • Submit button: in a few locales (fr, hy, ja, ka, km, ko, mn) it uses "send" or "post" instead of Filament's own submit label. Filament's label reads as "confirm" or "done" there, which is odd on a comment button.

Test plan

  • vendor/bin/pest passes (242 tests). Before the translations were added, the new coverage test failed for all 62 locales.
  • phpstan, pint, rector and composer normalize are clean.

Adds the 62 locales Filament ships that the package did not have yet, so
the comment form, the actions and the notifications read in the panel's
language instead of falling back to English. The wording follows each
language's own Filament translations.

TranslationsTest now also fails when a value is still the English text and
when a locale Filament ships has no translation. The README lists the
locales.
Copilot AI lite review requested due to automatic review settings September 25, 2026 09:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The broad multilingual translation set requires final human and native-speaker review.

Review effort: Lite
Findings: None

What changed in this PR

Adds comment translations for all Filament-supported locales, strengthens translation coverage tests, and documents supported locales.

Changes:

  • Added 62 locale translation files with 18 keys each.
  • Added checks for locale coverage and untranslated English values.
  • Updated README locale documentation.
File Summary
tests/​Unit/​TranslationsTest.php Validates translation completeness and locale coverage.
resources/​lang/​zh_TW/​comments.php Adds localized comment strings.
resources/​lang/​zh_HK/​comments.php Adds localized comment strings.
resources/​lang/​zh_CN/​comments.php Adds localized comment strings.
resources/​lang/​vi/​comments.php Adds localized comment strings.
resources/​lang/​uz/​comments.php Adds localized comment strings.
resources/​lang/​ur/​comments.php Adds localized comment strings.
resources/​lang/​uk/​comments.php Adds localized comment strings.
resources/​lang/​tr/​comments.php Adds localized comment strings.
resources/​lang/​th/​comments.php Adds localized comment strings.
resources/​lang/​tg/​comments.php Adds localized comment strings.
resources/​lang/​sw/​comments.php Adds localized comment strings.
resources/​lang/​sv/​comments.php Adds localized comment strings.
resources/​lang/​sr_Latn/​comments.php Adds localized comment strings.
resources/​lang/​sr_Cyrl/​comments.php Adds localized comment strings.
resources/​lang/​sq/​comments.php Adds localized comment strings.
resources/​lang/​sl/​comments.php Adds localized comment strings.
resources/​lang/​sk/​comments.php Adds localized comment strings.
resources/​lang/​ru/​comments.php Adds localized comment strings.
resources/​lang/​ro/​comments.php Adds localized comment strings.
resources/​lang/​pt/​comments.php Adds localized comment strings.
resources/​lang/​pt_BR/​comments.php Adds localized comment strings.
resources/​lang/​nl/​comments.php Adds localized comment strings.
resources/​lang/​ne/​comments.php Adds localized comment strings.
resources/​lang/​nb/​comments.php Adds localized comment strings.
resources/​lang/​my/​comments.php Adds localized comment strings.
resources/​lang/​ms/​comments.php Adds localized comment strings.
resources/​lang/​mn/​comments.php Adds localized comment strings.
resources/​lang/​mk/​comments.php Adds localized comment strings.
resources/​lang/​lv/​comments.php Adds localized comment strings.
resources/​lang/​lus/​comments.php Adds localized comment strings.
resources/​lang/​lt/​comments.php Adds localized comment strings.
resources/​lang/​ku/​comments.php Adds localized comment strings.
resources/​lang/​ko/​comments.php Adds localized comment strings.
resources/​lang/​km/​comments.php Adds localized comment strings.
resources/​lang/​ka/​comments.php Adds localized comment strings.
resources/​lang/​ja/​comments.php Adds localized comment strings.
resources/​lang/​it/​comments.php Adds localized comment strings.
resources/​lang/​id/​comments.php Adds localized comment strings.
resources/​lang/​hy/​comments.php Adds localized comment strings.
resources/​lang/​hu/​comments.php Adds localized comment strings.
resources/​lang/​hr/​comments.php Adds localized comment strings.
resources/​lang/​hi/​comments.php Adds localized comment strings.
resources/​lang/​he/​comments.php Adds localized comment strings.
resources/​lang/​fr/​comments.php Adds localized comment strings.
resources/​lang/​fil/​comments.php Adds localized comment strings.
resources/​lang/​fi/​comments.php Adds localized comment strings.
resources/​lang/​fa/​comments.php Adds localized comment strings.
resources/​lang/​eu/​comments.php Adds localized comment strings.
resources/​lang/​et/​comments.php Adds localized comment strings.
resources/​lang/​es/​comments.php Adds localized comment strings.
resources/​lang/​el/​comments.php Adds localized comment strings.
resources/​lang/​de/​comments.php Adds localized comment strings.
resources/​lang/​da/​comments.php Adds localized comment strings.
resources/​lang/​cs/​comments.php Adds localized comment strings.
resources/​lang/​ckb/​comments.php Adds localized comment strings.
resources/​lang/​ca/​comments.php Adds localized comment strings.
resources/​lang/​bs/​comments.php Adds localized comment strings.
resources/​lang/​bn/​comments.php Adds localized comment strings.
resources/​lang/​bg/​comments.php Adds localized comment strings.
resources/​lang/​az/​comments.php Adds localized comment strings.
resources/​lang/​ar/​comments.php Adds localized comment strings.
resources/​lang/​am/​comments.php Adds localized comment strings.
README.md Documents supported locales and validation behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@webard
webard merged commit b40fd65 into 2.x Sep 25, 2026
27 checks passed
@webard
webard deleted the feat/translations branch September 25, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants