Repository navigation
feat: translate the comments into every locale Filament ships - #7
Merged
Merged
Conversation
Adds the 62 locales Filament ships that the package did not have yet, so the comment form, the actions and the notifications read in the panel's language instead of falling back to English. The wording follows each language's own Filament translations. TranslationsTest now also fails when a value is still the English text and when a locale Filament ships has no translation. The README lists the locales.
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The broad multilingual translation set requires final human and native-speaker review.
Review effort: Lite
Findings: None
What changed in this PR
Adds comment translations for all Filament-supported locales, strengthens translation coverage tests, and documents supported locales.
Changes:
- Added 62 locale translation files with 18 keys each.
- Added checks for locale coverage and untranslated English values.
- Updated README locale documentation.
| File | Summary |
|---|---|
tests/Unit/TranslationsTest.php |
Validates translation completeness and locale coverage. |
resources/lang/zh_TW/comments.php |
Adds localized comment strings. |
resources/lang/zh_HK/comments.php |
Adds localized comment strings. |
resources/lang/zh_CN/comments.php |
Adds localized comment strings. |
resources/lang/vi/comments.php |
Adds localized comment strings. |
resources/lang/uz/comments.php |
Adds localized comment strings. |
resources/lang/ur/comments.php |
Adds localized comment strings. |
resources/lang/uk/comments.php |
Adds localized comment strings. |
resources/lang/tr/comments.php |
Adds localized comment strings. |
resources/lang/th/comments.php |
Adds localized comment strings. |
resources/lang/tg/comments.php |
Adds localized comment strings. |
resources/lang/sw/comments.php |
Adds localized comment strings. |
resources/lang/sv/comments.php |
Adds localized comment strings. |
resources/lang/sr_Latn/comments.php |
Adds localized comment strings. |
resources/lang/sr_Cyrl/comments.php |
Adds localized comment strings. |
resources/lang/sq/comments.php |
Adds localized comment strings. |
resources/lang/sl/comments.php |
Adds localized comment strings. |
resources/lang/sk/comments.php |
Adds localized comment strings. |
resources/lang/ru/comments.php |
Adds localized comment strings. |
resources/lang/ro/comments.php |
Adds localized comment strings. |
resources/lang/pt/comments.php |
Adds localized comment strings. |
resources/lang/pt_BR/comments.php |
Adds localized comment strings. |
resources/lang/nl/comments.php |
Adds localized comment strings. |
resources/lang/ne/comments.php |
Adds localized comment strings. |
resources/lang/nb/comments.php |
Adds localized comment strings. |
resources/lang/my/comments.php |
Adds localized comment strings. |
resources/lang/ms/comments.php |
Adds localized comment strings. |
resources/lang/mn/comments.php |
Adds localized comment strings. |
resources/lang/mk/comments.php |
Adds localized comment strings. |
resources/lang/lv/comments.php |
Adds localized comment strings. |
resources/lang/lus/comments.php |
Adds localized comment strings. |
resources/lang/lt/comments.php |
Adds localized comment strings. |
resources/lang/ku/comments.php |
Adds localized comment strings. |
resources/lang/ko/comments.php |
Adds localized comment strings. |
resources/lang/km/comments.php |
Adds localized comment strings. |
resources/lang/ka/comments.php |
Adds localized comment strings. |
resources/lang/ja/comments.php |
Adds localized comment strings. |
resources/lang/it/comments.php |
Adds localized comment strings. |
resources/lang/id/comments.php |
Adds localized comment strings. |
resources/lang/hy/comments.php |
Adds localized comment strings. |
resources/lang/hu/comments.php |
Adds localized comment strings. |
resources/lang/hr/comments.php |
Adds localized comment strings. |
resources/lang/hi/comments.php |
Adds localized comment strings. |
resources/lang/he/comments.php |
Adds localized comment strings. |
resources/lang/fr/comments.php |
Adds localized comment strings. |
resources/lang/fil/comments.php |
Adds localized comment strings. |
resources/lang/fi/comments.php |
Adds localized comment strings. |
resources/lang/fa/comments.php |
Adds localized comment strings. |
resources/lang/eu/comments.php |
Adds localized comment strings. |
resources/lang/et/comments.php |
Adds localized comment strings. |
resources/lang/es/comments.php |
Adds localized comment strings. |
resources/lang/el/comments.php |
Adds localized comment strings. |
resources/lang/de/comments.php |
Adds localized comment strings. |
resources/lang/da/comments.php |
Adds localized comment strings. |
resources/lang/cs/comments.php |
Adds localized comment strings. |
resources/lang/ckb/comments.php |
Adds localized comment strings. |
resources/lang/ca/comments.php |
Adds localized comment strings. |
resources/lang/bs/comments.php |
Adds localized comment strings. |
resources/lang/bn/comments.php |
Adds localized comment strings. |
resources/lang/bg/comments.php |
Adds localized comment strings. |
resources/lang/az/comments.php |
Adds localized comment strings. |
resources/lang/ar/comments.php |
Adds localized comment strings. |
resources/lang/am/comments.php |
Adds localized comment strings. |
README.md |
Documents supported locales and validation behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources/lang/{locale}/comments.phpfor the 62 locales Filament ships that were missing, so all 64 are now covered,enandplincluded. There are 18 keys per locale.TranslationsTestnow also checks:Worth a native speaker's look
lus(Mizo): "comment" and "quote" have no Filament equivalent, so these words are our own choice.ckb/ku(Sorani): the word for "quote" is our own choice.Test plan
vendor/bin/pestpasses (242 tests). Before the translations were added, the new coverage test failed for all 62 locales.