Make the parent org access callout on the team page collapsible - #14519
Open
anishanne wants to merge 5 commits into
Open
Make the parent org access callout on the team page collapsible#14519anishanne wants to merge 5 commits into
anishanne wants to merge 5 commits into
Conversation
garyhtou
reviewed
Aug 6, 2026
@indirect_access rescanned the whole ancestor position list once per user (O(users x positions), allocating a fresh array each time), and re-fetched this organization's own positions even though ancestor_organizer_positions already includes them. Group the positions by user in a single pass instead, and preload avatars so the user_mention per row doesn't hit ActiveStorage individually. Sort by role value rather than relying on "manager" sorting before "reader" alphabetically, and break ties by name so the order is stable. Also drops User#access_level_for, which no longer has any callers, and the em dash from the callout copy. Adds specs for the inherited-role rules and for the callout being collapsed by default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
The "The team behind X also has access to Y" callout takes up a lot of space on the team page.
Describe your changes
Makes the callout minimized by default.
Screen.Recording.2026-08-06.at.2.48.09.PM.mov