[Contractors] Normalize payee emails and downcase existing ones - #14507
Open
manuthecoder wants to merge 2 commits into
Open
[Contractors] Normalize payee emails and downcase existing ones#14507manuthecoder wants to merge 2 commits into
manuthecoder wants to merge 2 commits into
Conversation
garyhtou
requested changes
Aug 5, 2026
Comment on lines
+55
to
+58
| return true if user&.auditor? | ||
| return true if record.payee.legal_entity&.users&.include?(user) | ||
|
|
||
| user&.email.present? && user.email.casecmp?(record.payee.email.to_s) |
Member
There was a problem hiding this comment.
Suggested change
| return true if user&.auditor? | |
| return true if record.payee.legal_entity&.users&.include?(user) | |
| user&.email.present? && user.email.casecmp?(record.payee.email.to_s) | |
| return false if user.nil? | |
| return true if user.auditor? | |
| return true if record.payee.legal_entity&.users&.include?(user) | |
| user.email == record.payee.email |
Instead of using casecmp, we should update production data to downcase all existing emails.
It looks like in all cases, the page should not be accessible in transparency mode (when user is nil). I added it as a guard clause at the very beginning to simplify the logic in this method.
Member
There was a problem hiding this comment.
This should be a maintenance task.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14502