remove unneeded NULL check in do_receive - #685
Merged
Merged
Conversation
space is assigned only after the corresponding PN space is confirmed non-null (lib/quicly.c:7546). Payload processing cannot discard the active space: - Handshake packets may discard the Initial space, not their own. - HANDSHAKE_DONE is 1-RTT and discards the Handshake space, not Application (lib/quicly.c:7008). - The active Initial or Handshake space is discarded only after record_receipt (lib/quicly.c:7705). - Application space is freed only when freeing the connection.
deweerdt
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*space != NULL check is redundant with the current lifecycle.
space is assigned only after the corresponding PN space is confirmed non-null (lib/quicly.c:7546). Payload processing cannot discard the active space: