Skip to content

add position and allow 0 margin for text watermark #343

Open
fajrifernanda wants to merge 1 commit into
h2non:masterfrom
fajrifernanda:master
Open

add position and allow 0 margin for text watermark #343
fajrifernanda wants to merge 1 commit into
h2non:masterfrom
fajrifernanda:master

Conversation

@fajrifernanda

@fajrifernanda fajrifernanda commented Jul 13, 2020

Copy link
Copy Markdown

Add position(left and top) to set the position of text watermark

and allow 0 margin on text watermark

this is sample of 0 margin, left(0), top(imageheight-fontheight)
resize (1)

* fix text position

* refactor code line
@Eptarch

Eptarch commented Sep 14, 2020

Copy link
Copy Markdown

Hey, that's great! Just dropping in to say two things:

  1. It will probably be good to add tests to resizer_test.go and vips_test.go
  2. I am really looking forward for @h2non to accept this, because we're going to rely on Imaginary and this exact functionality in our project; and this PR allows these issues to be closed:

@fajrifernanda

Copy link
Copy Markdown
Author

@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr

@Leterax

Leterax commented Oct 7, 2021

Copy link
Copy Markdown

Any plans on merging this?

@huntrist

huntrist commented Mar 7, 2022

Copy link
Copy Markdown

please merge~

@Drabuna

Drabuna commented Jun 15, 2022

Copy link
Copy Markdown

bump

@suntong

suntong commented Dec 1, 2023

Copy link
Copy Markdown

@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr

Hi @fajrifernanda, did you add some tests to your project later?

@suntong

suntong commented Dec 1, 2023

Copy link
Copy Markdown

Oh~~~

This branch has conflicts that must be resolved now, after more than three years.

@suntong

suntong commented Dec 2, 2023

Copy link
Copy Markdown

Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?

@suntong

suntong commented Dec 2, 2023

Copy link
Copy Markdown

Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?

NVM, I got it -- suntong@44218a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants