Revamp Attendance Import and Export Functionality - #174
Open
tatokis wants to merge 7 commits into
Open
Conversation
Co-authored-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
Co-authored-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
This is more in line with general UI guidelines. In addition, the fa-cogs icon was replaced with fa-edit to be consistent with the other edit buttons. Co-authored-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
Co-authored-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
tatokis
force-pushed
the
attendance_book_spreadsheet_master
branch
from
August 2, 2026 13:48
1a7c12e to
ca3d6c2
Compare
The export spreadsheet functionality now splits activity attendance books into individual worksheets and summarizes attendance results into a 'Summary' worksheet. Additionally, some translations have been improved and file sanitization has been added to prevent illegal file names for non Linux users. Co-authored-by: Tasos Sahanidis <tasos@tasossah.com>
Co-authored-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
tatokis
force-pushed
the
attendance_book_spreadsheet_master
branch
from
August 10, 2026 15:23
ca3d6c2 to
dd072e8
Compare
Co-authored-by: Karl Fleischmann <fleischmann.karl@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates various changes improving ease of use regarding the attendance import/export workflow.
More specifically,
The new exported spreadsheets contain a new metadata field to distinguish spreadsheets exported with the new format in order to preserve backwards compatibility with previously exported files.
In addition, custom metadata was added that can be used in the future for additional functionality (such as asking the user if they are sure they are importing the correct spreadsheet to the correct activity).
Due to requiring certain new features from PHPSpreadsheet, we had to update it to the latest version. This has not resulted in any breaking changes.
In addition, a lean third party library was added (ondrej-vrto/php-filename-sanitize) to sanitise file names, especially useful for Windows users where filenames are restricted (as the exported filename is now named based on the course and activity). The code of the library was manually reviewed and was deemed to be of sufficient quality, and preferable to rolling our own.