test(e2e): analysis response to art-images on Atlas - #1183
Conversation
Reviewer's GuideAdds a new, Atlas-specific end-to-end API test that verifies an analysis response is returned for the art-images component against an Atlas instance, and performs a minor comment typo fix in an existing Atlas test file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Using
test.describe.onlywill cause all other e2e suites to be skipped when this file is present; consider removing.onlyso the Atlas tests run alongside the rest of the suite. - The hardcoded 20-minute
responseTimeoutis unusually large; consider making this configurable (e.g., via environment variable) to avoid excessively long runs in slower environments or CI.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `test.describe.only` will cause all other e2e suites to be skipped when this file is present; consider removing `.only` so the Atlas tests run alongside the rest of the suite.
- The hardcoded 20-minute `responseTimeout` is unusually large; consider making this configurable (e.g., via environment variable) to avoid excessively long runs in slower environments or CI.
## Individual Comments
### Comment 1
<location path="e2e/tests/api/features/analysis-atlas.ts" line_range="9" />
<code_context>
+
+const responseTimeout = 1200000; // 20 minutes
+
+test.describe.only("Analysis / Atlas", () => {
+ test.skip(
+ !process.env.ATLAS_ENV || process.env.ATLAS_ENV !== "true",
</code_context>
<issue_to_address>
**issue (testing):** Using `test.describe.only` will prevent other e2e tests from running when this file is included
`.only` will cause this suite to run in isolation whenever this file is loaded, which can hide regressions by skipping other e2e tests. Please remove `.only` or ensure this file is excluded from normal e2e runs via configuration.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| const responseTimeout = 1200000; // 20 minutes | ||
|
|
||
| test.describe.only("Analysis / Atlas", () => { |
There was a problem hiding this comment.
issue (testing): Using test.describe.only will prevent other e2e tests from running when this file is included
.only will cause this suite to run in isolation whenever this file is loaded, which can hide regressions by skipping other e2e tests. Please remove .only or ensure this file is excluded from normal e2e runs via configuration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 54.03% 54.09% +0.06%
==========================================
Files 269 250 -19
Lines 5904 5638 -266
Branches 1849 1756 -93
==========================================
- Hits 3190 3050 -140
+ Misses 2419 2331 -88
+ Partials 295 257 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Vilem Obratil <vobratil@redhat.com>
6a20d51 to
5827e0f
Compare
This is a single test that tests for TC-4487 against an Atlas instance.
Summary by Sourcery
Add an Atlas-specific e2e API test to verify analysis responses for pre-ingested art-images data.
Tests: