-
Notifications
You must be signed in to change notification settings - Fork 37
test(e2e): delete single and multiple SBOMs #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vobratil
wants to merge
1
commit into
guacsec:main
Choose a base branch
from
vobratil:api-delete-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| import { expect, test } from "../fixtures"; | ||
| import { | ||
| deleteSboms, | ||
| getFullSbomPaths, | ||
| uploadFiles, | ||
| } from "../helpers/general-helpers"; | ||
| import { logger } from "../../common/constants"; | ||
|
|
||
| // SBOMs to upload | ||
| const sbomDir = "tests/common/assets/sbom"; | ||
|
|
||
| const sbomSingle = ["cnv-4.17-product-older.json.bz2"]; | ||
|
|
||
| const sbomsMultiple = [ | ||
| "cnv-4.17-index-older.json.bz2", | ||
| "cnv-4.17-binary-1-older.json.bz2", | ||
| "cnv-4.17-binary-2-older.json.bz2", | ||
| "cnv-4.17-product-latest.json.bz2", | ||
| "cnv-4.17-index-latest.json.bz2", | ||
| "cnv-4.17-binary-1-latest.json.bz2", | ||
| "cnv-4.17-binary-2-latest.json.bz2", | ||
| ]; | ||
|
|
||
| test.describe("SBOM / Delete", () => { | ||
| test.describe.configure({ mode: "serial" }); | ||
|
|
||
| const sbomIdsDelete: string[] = []; | ||
|
|
||
| test.afterAll(async ({ axios }) => { | ||
| await deleteSboms(axios, sbomIdsDelete); | ||
| }); | ||
|
|
||
| test("Single existing SBOM", async ({ axios }) => { | ||
| const fullSbomPaths = getFullSbomPaths(sbomDir, sbomSingle); | ||
| const sbomIdSingle = await uploadFiles(axios, "sbom", fullSbomPaths); | ||
| sbomIdsDelete.push(...sbomIdSingle); | ||
|
|
||
| // Delete the SBOM | ||
| const response = await axios.delete( | ||
| `/api/v3/sbom/${encodeURIComponent(sbomIdSingle[0])}`, | ||
| ); | ||
| if (response.status !== 204) { | ||
| logger.error( | ||
| `Delete single existing SBOM failed with status ${response.status}:`, | ||
| response.data, | ||
| ); | ||
| } | ||
| expect(response.status).toBe(204); | ||
|
|
||
| // Verify that the SBOM is deleted | ||
| const getResponse = await axios.get( | ||
| `/api/v3/sbom/${encodeURIComponent(sbomIdSingle[0])}`, | ||
| { validateStatus: null }, | ||
| ); | ||
| expect(getResponse.status).toBe(404); | ||
| }); | ||
|
|
||
| test("Multiple existing SBOMs", async ({ axios }) => { | ||
| const fullSbomPaths = getFullSbomPaths(sbomDir, sbomsMultiple); | ||
| const sbomIdsMultiple = await uploadFiles(axios, "sbom", fullSbomPaths); | ||
| sbomIdsDelete.push(...sbomIdsMultiple); | ||
|
|
||
| const response = await axios.delete("/api/v3/sbom", { | ||
| data: sbomIdsMultiple, | ||
| }); | ||
| if (response.status !== 204) { | ||
| logger.error( | ||
| `Delete multiple existing SBOMs failed with status ${response.status}:`, | ||
| response.data, | ||
| ); | ||
| } | ||
| expect(response.status).toBe(204); | ||
|
|
||
| // Verify that all SBOMs are deleted | ||
| for (const id of sbomIdsMultiple) { | ||
| const getResponse = await axios.get( | ||
| `/api/v3/sbom/${encodeURIComponent(id)}`, | ||
| { validateStatus: null }, | ||
| ); | ||
| expect(getResponse.status).toBe(404); | ||
| } | ||
| }); | ||
|
|
||
| test("Single non-existent SBOM", async ({ axios }) => { | ||
| const nonExistentId = Array.from( | ||
| { length: 45 }, | ||
| () => | ||
| "abcdefghijklmnopqrstuvwxyz0123456789"[Math.floor(Math.random() * 36)], | ||
| ).join(""); | ||
|
|
||
| const response = await axios.delete( | ||
| `/api/v3/sbom/${encodeURIComponent(nonExistentId)}`, | ||
| { validateStatus: null }, | ||
| ); | ||
| if (response.status !== 204) { | ||
| logger.error( | ||
| `Delete single non-existent SBOM failed with status ${response.status}:`, | ||
| response.data, | ||
| ); | ||
| } | ||
| expect(response.status).toBe(204); | ||
| }); | ||
|
|
||
| test("Multiple non-existent SBOMs", async ({ axios }) => { | ||
| const nonExistentIds = Array.from({ length: 7 }, () => | ||
| Array.from( | ||
| { length: 45 }, | ||
| () => | ||
| "abcdefghijklmnopqrstuvwxyz0123456789"[ | ||
| Math.floor(Math.random() * 36) | ||
| ], | ||
| ).join(""), | ||
| ); | ||
|
|
||
| const response = await axios.delete("/api/v3/sbom", { | ||
| data: nonExistentIds, | ||
| validateStatus: null, | ||
| }); | ||
| if (response.status !== 204) { | ||
| logger.error( | ||
| `Delete multiple non-existent SBOMs failed with status ${response.status}:`, | ||
| response.data, | ||
| ); | ||
| } | ||
| expect(response.status).toBe(204); | ||
| }); | ||
| }); | ||
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Avoid randomness for non-existent IDs to keep tests deterministic and reproducible
Using
Math.randomhere makes failures hard to reproduce and, in rare cases, could even generate a valid ID. In e2e tests it’s preferable to use a fixed clearly invalid ID pattern (e.g."nonexistent-sbom-id-...") or a seeded deterministic generator so runs remain predictable while still exercising the "non-existent" path.