Skip to content

Fix: "View Vulnerability" link not vertically aligned to bottom - #1171

Open
stanislavsemeniuk wants to merge 1 commit into
guacsec:mainfrom
stanislavsemeniuk:fix/highest-vulnerabilities
Open

Fix: "View Vulnerability" link not vertically aligned to bottom#1171
stanislavsemeniuk wants to merge 1 commit into
guacsec:mainfrom
stanislavsemeniuk:fix/highest-vulnerabilities

Conversation

@stanislavsemeniuk

@stanislavsemeniuk stanislavsemeniuk commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

Just because container was written like that:

<Flex
 direction={{ default: "column", md: "row" }}
 alignItems={{ default: "alignItemsStretch" }}
 >

When direction was changed from default:"column" to md:"row" alignItems was overwritten with patternfly default fro row

Related Issues

Fixes TC-5199

Type of Change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation
  • Other (describe below)

Testing

  • All tests pass (npm test)
  • No lint errors (npm run lint)
  • No type errors (TypeScript compiles cleanly)
  • New/changed UI behavior visually verified in browser
  • Mock data updated if API types changed

Screenshots

Screenshot 2026-07-21 at 16 22 16

Summary by Sourcery

Bug Fixes:

  • Prevent PatternFly default flex alignment from overriding the intended vertical alignment of the vulnerability cards across screen sizes.

@sourcery-ai

sourcery-ai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures the Flex container keeps stretch alignment across all responsive breakpoints so the 'View Vulnerability' link remains bottom-aligned, regardless of the layout direction change from column to row.

State diagram for Flex alignment across responsive breakpoints

stateDiagram-v2
  [*] --> default_state

  state default_state {
    [*] --> column_layout
    column_layout: direction=column
    note right of column_layout
      alignItems=alignItemsStretch
    end note
  }

  default_state --> sm when [viewport >= sm]
  sm: direction=column
  note right of sm
    alignItems=alignItemsStretch
  end note

  sm --> md when [viewport >= md]
  md: direction=row
  note right of md
    alignItems=alignItemsStretch
  end note
Loading

File-Level Changes

Change Details Files
Make Flex alignItems consistently use stretch alignment across breakpoints to preserve vertical bottom alignment of child content.
  • Expanded alignItems prop from a single default value to an explicit object covering default, sm, and md breakpoints.
  • Set alignItems to alignItemsStretch for default, sm, and md to prevent PatternFly from overriding alignment when direction changes to row.
  • Left the existing responsive direction configuration (column on default, row on md) intact while fixing the alignment behavior.
client/src/app/pages/home/components/WhatNeedsAttention.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.01%. Comparing base (ed87429) to head (e7a73c1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   54.03%   54.01%   -0.02%     
==========================================
  Files         269      269              
  Lines        5904     5904              
  Branches     1849     1849              
==========================================
- Hits         3190     3189       -1     
  Misses       2419     2419              
- Partials      295      296       +1     
Flag Coverage Δ
e2e 72.01% <ø> (-0.03%) ⬇️
unit 6.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants