core: normalize service config number values#12826
Open
codingkiddo wants to merge 1 commit into
Open
Conversation
|
|
Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
6253f6e to
679fdae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12815
This updates default service config validation to accept numeric values represented as
Number, not onlyDouble.Common JSON parsers may deserialize integer-looking JSON values such as
maxAttempts: 4andbackoffMultiplier: 2asInteger, which previously causeddefaultServiceConfig()to fail withIllegalArgumentException.The values are normalized to
Doublewhen copied into the validated service config, preserving the existing internal representation expected by the service config parsing code.Tests were updated to cover direct and nested integer numeric values.
Tested with: