fix(subagent-log): default AFK_SUBAGENT_LOG to off — raw tool args written without redaction (#1318) - #1359
Merged
Merged
Conversation
…itten without redaction (#1318)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1318.
P1 security fix.
SubagentLogWriterserialized fullOutputEventobjects including raw tool argument payloads (bash commands, file paths, potentially API keys) to disk. This was always-on by default (AFK_SUBAGENT_LOG=1), circumventing the trace subsystem's deliberate privacy posture of storing onlyinputBytes.Changed the default to off (
AFK_SUBAGENT_LOG=0), consistent with the opt-in posture ofAFK_CAPTURE_SUBAGENT_PROMPTSandAFK_CAPTURE_SUBAGENT_OUTPUT.Changes
src/config/env.ts-- removeddefault: '1', addedexample: '1'src/agent/subagent/log.ts--isEnabled()from!== '0'to=== '1'src/agent/subagent.ts-- updated inline commentsrc/agent/subagent/log.test.ts-- updated unset-case expectationdocs/env-registry.json+docs/env-registry.md-- syncedVerification
pnpm lintclean