-
Notifications
You must be signed in to change notification settings - Fork 11
fix(safety): block direct launchctl/systemctl service registration #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9054ff9
fix(safety): block direct launchctl/systemctl service registration (#…
griffinwork40 e80c14d
fix(pr-1311): address review feedback — kickstart/enable coverage, en…
griffinwork40 77314aa
fix(pr-1311): handle --flag=value in service-registration regex prefix
griffinwork40 1d673d8
fix(pr-1311): address review — test coverage gaps and trailing-space …
griffinwork40 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command form used by this repository is
systemctl --user daemon-reload/systemctl --user enable --now(src/service/systemd/install.ts), but this regex requires the subcommand to immediately followsystemctl. I checkedsystemctl --help, which documents--useras the global option that connects to the user service manager; consequently, the valid persistent registration commandsystemctl --user enable --now attacker.serviceproduces no safe-destruct match, and the identical literals inBASH_HIGHclassify it only as medium. Account for global options before matching the blocked subcommands.Useful? React with 👍 / 👎.