Remove dead _validate_topic function - #294
Merged
isolomatov-gd merged 1 commit intoAug 18, 2026
Merged
Conversation
Zero call sites in src/ -- both places that could use it (get_context_instructions, query_instructions) hardcode topic=None with a comment explaining topic filtering was intentionally disabled to reduce noise. Leaving the validator in place implies topic filtering is still active, which is misleading. Fixes griddynamics#256
isolomatov-gd
marked this pull request as draft
August 18, 2026 17:32
isolomatov-gd
marked this pull request as ready for review
August 18, 2026 17:32
Contributor
Rosetta Triage ReviewSummary: Removes the dead Findings:
Caveats:
Automated triage by Rosetta agent |
isolomatov-gd
approved these changes
Aug 18, 2026
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256.
`_validate_topic` (`src/rosetta-mcp-server/rosetta_mcp/server.py:545`)
has zero call sites in `src/`. Both places that could use it
(`get_context_instructions`, `query_instructions`) hardcode
`topic=None` with an inline comment explaining topic filtering was
intentionally disabled to reduce noise. Leaving the validator in place
implies topic filtering is still active, which is misleading -- removed
per the issue's own preferred option (YAGNI) and the automated triage
comment's recommendation.
Verified: grepped for every reference to `_validate_topic` before and
after -- only the definition existed, confirming this is genuinely dead
code, not something with a hidden caller. Full test suite: 334/334
passing, no regressions.