Skip to content

fix: honour READ_ONCE_TTL=0 instead of falling back to the default #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isolomatov-gd merged 1 commit into from
Aug 19, 2026
Merged

fix: honour READ_ONCE_TTL=0 instead of falling back to the default #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/hooks/src/hooks/read-once-shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,16 @@ export interface ReadOnceConfig {
disabled: boolean;
}

export const getReadOnceConfig = (): ReadOnceConfig => ({
mode: process.env.READ_ONCE_MODE === 'deny' ? 'deny' : 'warn',
ttlMs: Math.max(1, parseInt(process.env.READ_ONCE_TTL ?? '', 10) || DEFAULT_TTL_MS / 1000) * 1000,
disabled: process.env.READ_ONCE_DISABLED === '1',
});
export const getReadOnceConfig = (): ReadOnceConfig => {
const ttlSecs = Number.isNaN(parseInt(process.env.READ_ONCE_TTL ?? '', 10))
? DEFAULT_TTL_MS / 1000
: parseInt(process.env.READ_ONCE_TTL ?? '', 10);
return {
mode: process.env.READ_ONCE_MODE === 'deny' ? 'deny' : 'warn',
ttlMs: Math.max(1, ttlSecs) * 1000,
disabled: process.env.READ_ONCE_DISABLED === '1',
};
};

export const isFullRead = (ctx: HookContext): boolean =>
!('offset' in ctx.toolInput) && !('limit' in ctx.toolInput);
Expand Down
16 changes: 15 additions & 1 deletion src/hooks/tests/read-once.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ vi.mock('../src/runtime/state-store', () => ({
import { runHook } from '../src/runtime/run-hook';
import { readOnceHook } from '../src/hooks/read-once';
import { readOnceResetHook } from '../src/hooks/read-once-reset';
import { readReadOnceState, READ_ONCE_NAMESPACE } from '../src/hooks/read-once-shared';
import {
getReadOnceConfig,
readReadOnceState,
READ_ONCE_NAMESPACE,
} from '../src/hooks/read-once-shared';

const makeClaudeRead = (
filePath: string,
Expand Down Expand Up @@ -172,6 +176,16 @@ describe('read-once', () => {
expect(result).toBeNull();
});

test('zero TTL is honoured as the floored minimum, not the default', () => {
process.env.READ_ONCE_TTL = '0';
expect(getReadOnceConfig().ttlMs).toBe(1000);
});

test('missing TTL falls back to the default', () => {
delete process.env.READ_ONCE_TTL;
expect(getReadOnceConfig().ttlMs).toBe(20 * 60 * 1000);
});

test('preCompact reset clears the ledger for the current session', async () => {
await runHookWithRaw(readOnceHook, makeClaudeRead(filePath));
await runHookWithRaw(readOnceResetHook, makeClaudePreCompact('claude-session-001'));
Expand Down
Loading