Skip to content

fix(cli): honor page size for filtered cleanup #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): honor page size for filtered cleanup #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rosetta-cli/rosetta_cli/commands/cleanup_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,13 @@ def _get_filtered_documents(
# Filter by tags (metadata condition)
tags_list = self._parse_tags(args.tags)
filtered_documents = document_service.filter_documents_by_tags(
dataset, tags_list
dataset, tags_list, limit=self.config.page_size
)
print(f"\nFiltered {len(filtered_documents)} document(s) with tags: {', '.join(tags_list)}\n")
elif args.prefix:
# Filter by prefix
filtered_documents = document_service.filter_documents_by_prefix(
dataset, args.prefix
dataset, args.prefix, limit=self.config.page_size
)
print(f"\nFiltered {len(filtered_documents)} document(s) matching prefix '{args.prefix}'\n")
else:
Expand Down
36 changes: 36 additions & 0 deletions src/rosetta-cli/tests/test_cleanup_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
from argparse import Namespace
from types import SimpleNamespace
from unittest.mock import Mock

import pytest
from rosetta_cli.commands.cleanup_command import CleanupCommand


@pytest.mark.parametrize(
("args", "method_name", "filter_value"),
[
(
Namespace(tags="one,two", prefix=None),
"filter_documents_by_tags",
["one", "two"],
),
(Namespace(tags=None, prefix="guide-"), "filter_documents_by_prefix", "guide-"),
],
)
def test_filtered_cleanup_uses_configured_page_size(
monkeypatch, args, method_name, filter_value
):
document_service = Mock()
getattr(document_service, method_name).return_value = []
monkeypatch.setattr(
"rosetta_cli.commands.cleanup_command.DocumentService",
lambda client: document_service,
)
command = CleanupCommand(SimpleNamespace(), SimpleNamespace(page_size=2048))
dataset = SimpleNamespace()

command._get_filtered_documents(dataset, SimpleNamespace(), args)

getattr(document_service, method_name).assert_called_once_with(
dataset, filter_value, limit=2048
)
Loading