Skip to content

Demo: introduce ShellCheck violation #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-Lopez246 wants to merge 2 commits into
base: fix/ci-pipeline
Choose a base branch
from
Open

Demo: introduce ShellCheck violation #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82ee4b
Demo: introduce ShellCheck violation
Daniel-Lopez246 Feb 20, 2026
7a4e406
Quote variable in demo_shellcheck_break function
Daniel-Lopez246 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Backend/test/smoke_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,10 @@ test_shutdown() {
assert_contains "$calls" "ip link show wlan0"
}

test_shutdown
demo_shellcheck_break() {
local name="Sprint 7"
echo "$name"
Comment on lines +91 to +92
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The local variable name is unnecessary as it's only used once. It can be inlined to improve conciseness and resolve the associated ShellCheck warning (SC2034).

Suggested change
local name="Sprint 7"
echo "$name"
echo "Sprint 7"
References
  1. ShellCheck SC2034: A variable appears to be unused. This can indicate dead code or a typo. It's better to remove unused variables to improve code clarity.

}

test_shutdown
demo_shellcheck_break
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This function call prints to standard output, which can clutter test logs. In automated tests, output should typically be suppressed unless it's being captured for assertions. Consider redirecting the output to /dev/null.

Suggested change
demo_shellcheck_break
demo_shellcheck_break > /dev/null

Loading