fix(devtools): correct private field type in react-devtools-fusebox package.json#705
Open
fix(devtools): correct private field type in react-devtools-fusebox package.json#705
Conversation
…ackage.json The 'private' field in package.json must be a boolean, not a string. npm specification requires boolean values for this field. Fixes #35793
Greptile SummaryThis is a one-line metadata correctness fix: the
Confidence Score: 5/5
Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: packages/react-devtools-fusebox/package.json
Line: 4
Comment:
**Same issue exists in two other packages**
The fix here is correct. However, the same string-instead-of-boolean mistake exists in two other `package.json` files in the repository that were not covered by this PR:
- `compiler/packages/react-forgive/client/package.json` (line 2): `"private": "true"`
- `compiler/packages/react-forgive/server/package.json` (line 2): `"private": "true"`
It would be worth extending this fix to cover those files as well for consistency.
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: 022949a |
| "name": "react-devtools-fusebox", | ||
| "version": "0.0.0", | ||
| "private": "true", | ||
| "private": true, |
There was a problem hiding this comment.
Same issue exists in two other packages
The fix here is correct. However, the same string-instead-of-boolean mistake exists in two other package.json files in the repository that were not covered by this PR:
compiler/packages/react-forgive/client/package.json(line 2):"private": "true"compiler/packages/react-forgive/server/package.json(line 2):"private": "true"
It would be worth extending this fix to cover those files as well for consistency.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react-devtools-fusebox/package.json
Line: 4
Comment:
**Same issue exists in two other packages**
The fix here is correct. However, the same string-instead-of-boolean mistake exists in two other `package.json` files in the repository that were not covered by this PR:
- `compiler/packages/react-forgive/client/package.json` (line 2): `"private": "true"`
- `compiler/packages/react-forgive/server/package.json` (line 2): `"private": "true"`
It would be worth extending this fix to cover those files as well for consistency.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#36029
Original author: MorikawaSouma
Summary
The
privatefield inpackages/react-devtools-fusebox/package.jsonwas incorrectly set as a string"true"instead of a booleantrue.According to the npm package.json specification, the
privatefield must be a boolean value.Fix
Changed:
To:
Test Plan
Fixes #35793