Skip to content

fix(devtools): correct private field type in react-devtools-fusebox package.json#705

Open
everettbu wants to merge 1 commit intomainfrom
fix/fusebox-private-field
Open

fix(devtools): correct private field type in react-devtools-fusebox package.json#705
everettbu wants to merge 1 commit intomainfrom
fix/fusebox-private-field

Conversation

@everettbu
Copy link
Copy Markdown

Mirror of facebook/react#36029
Original author: MorikawaSouma


Summary

The private field in packages/react-devtools-fusebox/package.json was incorrectly set as a string "true" instead of a boolean true.

According to the npm package.json specification, the private field must be a boolean value.

Fix

Changed:

"private": "true"

To:

"private": true

Test Plan

  • Verify the package.json is valid JSON
  • No functional changes, only metadata correction

Fixes #35793

…ackage.json

The 'private' field in package.json must be a boolean, not a string.
npm specification requires boolean values for this field.

Fixes #35793
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 13, 2026

Greptile Summary

This is a one-line metadata correctness fix: the private field in packages/react-devtools-fusebox/package.json is changed from the string "true" to the boolean true, conforming to the npm package.json specification. The change is correct and has no functional impact on build or runtime behaviour.

  • Fix is accurate — npm treats any non-boolean value for private inconsistently across tooling; using the boolean true is the spec-compliant form.
  • Two other packages with the same issuecompiler/packages/react-forgive/client/package.json and compiler/packages/react-forgive/server/package.json both still contain "private": "true" (string) and were not included in this PR.

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, non-functional metadata correction with no runtime impact.
  • The change is a single character-class correction ("true"true) in a package.json field that has no effect on build scripts, dependencies, or runtime behaviour. The fix is unambiguously correct per the npm specification.
  • No files require special attention. Optionally extend the fix to compiler/packages/react-forgive/client/package.json and compiler/packages/react-forgive/server/package.json.

Important Files Changed

Filename Overview
packages/react-devtools-fusebox/package.json Corrects the private field from a string "true" to a boolean true, aligning with the npm package.json specification.

Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
This is a comment left during a code review.
Path: packages/react-devtools-fusebox/package.json
Line: 4

Comment:
**Same issue exists in two other packages**

The fix here is correct. However, the same string-instead-of-boolean mistake exists in two other `package.json` files in the repository that were not covered by this PR:

- `compiler/packages/react-forgive/client/package.json` (line 2): `"private": "true"`
- `compiler/packages/react-forgive/server/package.json` (line 2): `"private": "true"`

It would be worth extending this fix to cover those files as well for consistency.

How can I resolve this? If you propose a fix, please make it concise.

Last reviewed commit: 022949a

"name": "react-devtools-fusebox",
"version": "0.0.0",
"private": "true",
"private": true,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue exists in two other packages

The fix here is correct. However, the same string-instead-of-boolean mistake exists in two other package.json files in the repository that were not covered by this PR:

  • compiler/packages/react-forgive/client/package.json (line 2): "private": "true"
  • compiler/packages/react-forgive/server/package.json (line 2): "private": "true"

It would be worth extending this fix to cover those files as well for consistency.

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react-devtools-fusebox/package.json
Line: 4

Comment:
**Same issue exists in two other packages**

The fix here is correct. However, the same string-instead-of-boolean mistake exists in two other `package.json` files in the repository that were not covered by this PR:

- `compiler/packages/react-forgive/client/package.json` (line 2): `"private": "true"`
- `compiler/packages/react-forgive/server/package.json` (line 2): `"private": "true"`

It would be worth extending this fix to cover those files as well for consistency.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants