Disable Null Propagation Proposal#1694
Merged
benjie merged 3 commits intographql:mainfrom Mar 19, 2025
Merged
Conversation
martinbonnin
approved these changes
Mar 9, 2025
martinbonnin
reviewed
Mar 9, 2025
Comment on lines
+176
to
+183
| While this proposal focuses on a simple boolean directive, future extensions might consider additional error behaviors: | ||
|
|
||
| - `PROPAGATE`: Current default behavior (errors propagate up) | ||
| - `NULL`: Replace errored positions with null | ||
| - `ABORT`: Abort the entire request on any error | ||
| - `INLINE`: Replace errored positions with an error representation | ||
|
|
||
| These additional behaviors are not part of this proposal but may be considered in future iterations. |
Contributor
There was a problem hiding this comment.
I would just punt this as it's already part of "alternatives considered" below
benjie
requested changes
Mar 19, 2025
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Giving a quick link to the original proposal/spec edits for this, and removing INLINE as discussed there
benjie
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.