Add status check for default value PR stack#1248
Conversation
should just take a minute or two, just want to re-iterate the call(s?) to action involved
7dd3a0b to
cbc383e
Compare
|
@yaacovCR How well do you feel the Spec PR matches up with the GraphQL.js implementation? IIRC (and this was over a year ago, so my memory is very fuzzy on the subject) the GraphQL.js implementation evolved and I wasn't sure whether or not the spec reflected it any more - given you recently rebased both maybe you have a better feel for it? |
|
@benjie -- considering the number of changes, it is certainly tough to say, and so the more eyes on board the better! The main breaking change within graphql-js (besides function names/signatures) is that default values when supplied programmatically should be in the same domain as variable values, i.e. they should be external, and not internal. To quote @leebyron see graphql/graphql-js#3814 referencing the earlier PR:
This seems to still match the spec PR change pretty well! |
should just take a minute or two, just want to re-iterate the call(s?) to action involved