Skip to content

fix(DeferStreamDirectiveOnRootFieldRule): handle fragment cycles #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaacovCR merged 1 commit into from
Jul 20, 2026
Merged

fix(DeferStreamDirectiveOnRootFieldRule): handle fragment cycles #4838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/validation/__tests__/DeferStreamDirectiveOnRootFieldRule-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,29 @@ describe('Validate: Defer/Stream directive on root field', () => {
},
]);
});
it('Fragment spread cycle on root mutation field', () => {
expectValid(`
mutation {
...rootFragment
}
fragment rootFragment on MutationRoot {
...otherFragment
}
fragment otherFragment on MutationRoot {
...rootFragment
}
`);
});
it('Self-referencing fragment spread on root mutation field', () => {
expectValid(`
mutation {
...rootFragment
}
fragment rootFragment on MutationRoot {
...rootFragment
}
`);
});
it('Defer inline fragment spread on root mutation field', () => {
expectErrors(`
mutation {
Expand Down
2 changes: 1 addition & 1 deletion src/validation/rules/DeferStreamDirectiveOnRootFieldRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ function forbidDeferStream({
if (visitedFragments.has(fragmentName)) {
continue;
}
visitedFragments.add(fragmentName);
const fragment = fragments.get(fragmentName);
if (fragment) {
const defer = getDeferDirective(selection);
Expand All @@ -141,7 +142,6 @@ function forbidDeferStream({
visitedFragments,
});
}
visitedFragments.add(fragmentName);
} else if (selection.kind === 'InlineFragment') {
const defer = getDeferDirective(selection);
if (defer !== undefined) {
Expand Down
Loading