Skip to content

Fix valueFromAST variable own-property checks#4652

Open
abishekgiri wants to merge 2 commits intographql:16.x.xfrom
abishekgiri:fix-value-from-ast-own-property-check
Open

Fix valueFromAST variable own-property checks#4652
abishekgiri wants to merge 2 commits intographql:16.x.xfrom
abishekgiri:fix-value-from-ast-own-property-check

Conversation

@abishekgiri
Copy link
Copy Markdown

@abishekgiri abishekgiri commented Apr 2, 2026

Summary

Fixes an issue in valueFromAST where own-property checks were not properly enforced, which could lead to incorrect handling of inherited properties.

Changes

  • Updated own-property checks to ensure only direct properties are considered
  • Prevent unintended prototype chain access

Testing

  • Verified behavior manually with edge cases
  • Existing tests pass locally

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

@abishekgiri is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 2, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: abishekgiri / name: Abishek Kumar Giri (702e107)
  • ✅ login: abishekgiri / name: giria660 (89efacc)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@abishekgiri
Copy link
Copy Markdown
Author

Status update

  • Fixed valueFromAST() to use own-property checks when deciding whether a variable was provided.
  • Added regression coverage for omitted prototype-colliding names like toString across scalar, list, and input-object cases.
  • Results: targeted mocha, eslint, and prettier checks passed for this change.
  • tsc in this environment still reports existing external errors from ../node_modules/@types/react-dom, which are outside this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant