Remove oneof validation from values of correct type#4453
Merged
JoviDeCroock merged 2 commits into16.x.xfrom Jul 7, 2025
Merged
Remove oneof validation from values of correct type#4453JoviDeCroock merged 2 commits into16.x.xfrom
JoviDeCroock merged 2 commits into16.x.xfrom
Conversation
JoviDeCroock
force-pushed
the
remove-oneof-validation-from-values-of-correct-type
branch
from
9947d01 to
5cea229
Compare
yaacovCR
approved these changes
Jul 7, 2025
JoviDeCroock
deleted the
remove-oneof-validation-from-values-of-correct-type
branch
JoviDeCroock
added
the
PR: polish 💅
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Feb 20, 2026
- graphql#4363 and graphql#4453 on 16.x.x had some tests missing from graphql#4194 on next
yaacovCR
added a commit
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #4445
Fixes #4443
VariablesInAllowedPositionRulealready validates this