Skip to content

Fix LSP not loading .js and .ts files correctly #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
witoszekdev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix LSP not loading .js and .ts files correctly #4180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffcd542
fix: update graphql-config
witoszekdev Mar 25, 2026
8052aaa
add changeset
witoszekdev Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/green-lies-tap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'graphql-language-service-server': patch
'graphql-language-service': patch
'vscode-graphql-execution': patch
'graphql-language-service-cli': patch
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset marks graphql-language-service-cli for a patch release, but this PR doesn’t change that package (and it doesn’t directly depend on graphql-config). Consider removing it from the changeset, or update the CLI’s dependency constraints in a way that makes this release meaningful (e.g., if you intend to pin/bump graphql-language-service-server there).

Suggested change
'graphql-language-service-cli': patch

Copilot uses AI. Check for mistakes.
---

fix: update `graphql-config` to 5.1.5, this fixes issues with config from graphql.config.js / .ts files not being respected
2 changes: 1 addition & 1 deletion packages/graphql-language-service-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"dotenv": "10.0.0",
"fast-glob": "^3.2.7",
"glob": "^7.2.0",
"graphql-config": "5.0.3",
"graphql-config": "5.1.5",
Comment on lines 50 to +52
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR relies on graphql-config@5.1.5 to fix loading graphql.config.{js,ts} files, but the existing test suite here appears to only exercise YAML/JSON configs (and _loadConfigOrSkip tests don’t validate JS/TS config parsing). Please add a regression test that loads an actual graphql.config.js and/or graphql.config.ts fixture and asserts the config is read correctly, to prevent this bug from returning on future dependency updates.

Copilot uses AI. Check for mistakes.
"graphql-language-service": "^5.3.1",
"lru-cache": "^10.2.0",
"mkdirp": "^1.0.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/graphql-language-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@types/picomatch": "^2.3.0",
"benchmark": "^2.1.4",
"graphql": "^16.9.0",
"graphql-config": "5.0.3",
"graphql-config": "5.1.5",
"lodash": "^4.17.15",
"platform": "^1.3.5",
"ts-node": "^8.10.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-graphql-execution/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"cosmiconfig-toml-loader": "^1.0.0",
"dotenv": "10.0.0",
"graphql": "^16.9.0 || ^17.0.0-alpha.2",
"graphql-config": "5.0.3",
"graphql-config": "5.1.5",
"graphql-tag": "2.12.6",
"graphql-ws": "5.10.0",
"nullthrows": "1.1.1",
Expand Down
Loading
Loading