Skip to content

chore: deduplicate zero-collection test#1321

Closed
Olexandr88 wants to merge 1 commit into
graphprotocol:mainfrom
Olexandr88:patch-2
Closed

chore: deduplicate zero-collection test#1321
Olexandr88 wants to merge 1 commit into
graphprotocol:mainfrom
Olexandr88:patch-2

Conversation

@Olexandr88
Copy link
Copy Markdown

Removed test case for collecting zero tokens.

Removed test case for collecting zero tokens.
@RembrandtK
Copy link
Copy Markdown
Contributor

Thanks for the cleanup effort! However, these two tests aren't actually duplicates — they cover different scenarios:

  • The one at line 636 runs inside a parameterized loop with delegation and varied fee/tax configurations (4 combinations).
  • The one at line 772 (removed here) runs with default parameters and no delegation.

Since they exercise different code paths through the rebate and fee distribution logic, I think we should keep both. Closing in favour of keeping the existing coverage.

@RembrandtK RembrandtK closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants