Replace "whitelist/blacklist" with "allowed/blocked"#568
Replace "whitelist/blacklist" with "allowed/blocked"#568gwaldo wants to merge 13 commits intographite-project:masterfrom gwaldo:master
Conversation
…or of allowed/blocked
…cts to allowed_metricsRejects
…r to see progress
|
Alright, @graphite-project/committers I would love a review. Please make it a hearty review, especially given my relative weakness with Python, and knowledge of this particular codebase. Everything that I found to change was discovered by gratuitous grepping along the lines of |
|
I haven't done any work on graphite-web yet. I don't know if I'll get to work on it tonight, but we'll see. If everything looks good, but we want to wait until both apps' PRs are ready, I'm cool with that. |
| # PID_DIR = %(STORAGE_DIR)s/ | ||
| # STORAGE_DIR = $GRAPHITE_STORAGE_DIR | ||
| # LOCAL_DATA_DIR = %(STORAGE_DIR)s/whisper/ | ||
| # USE_METRIC_FILTERS = %(STORAGE_DIR)s/lists/ |
There was a problem hiding this comment.
This should be METRIC_FILTERS_DIR, no?
|
It looks like this isn't completely backwards compatible yet afa the parser and settings code. We need to be additive with the new stuff but leave the old stuff in place (not in examples/docs/confs, but in the aforementioned parser/settings). Make sense? |
|
Thank you, @obfuscurity. I haven't had time to look at this since Monday, but I'd had a suspicion that I'd missed one of the backwards-compatibility features. I'll see what I can do this weekend. I need to rebase and proceed. I've updated the status in the first comment to reflect that this isn't yet ready for merge. |
|
Closing in favor of #591. |
2 participants
ref #567
STATUS: Not yet ready to merge. Reviews and edits welcome