Skip to content

Fix return type of simplifyParsedResolveInfoFragmentWithType #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhritzkiv wants to merge 2 commits into from
Closed

Fix return type of simplifyParsedResolveInfoFragmentWithType #872

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
247e672
Update index.ts
dhritzkiv May 13, 2025
72dacae
Fix definition of `fields` in simplifyParsedResolveInfoFragmentWithTy…
dhritzkiv Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/graphql-parse-resolve-info/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export function simplifyParsedResolveInfoFragmentWithType(
type: GraphQLType
) {
const { fieldsByTypeName } = parsedResolveInfoFragment;
const fields = {};
const fields: ResolveTree = {};
Copy link
Copy Markdown
Member

@benjie benjie Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

src/index.ts:355:9 - error TS2739: Type '{}' is missing the following properties from type 'ResolveTree': name, alias, args, fieldsByTypeName

355   const fields: ResolveTree = {};

const strippedType = getNamedType(type);
if (isCompositeType(strippedType)) {
Object.assign(fields, fieldsByTypeName[strippedType.name]);
Expand Down
Loading