Gedcom warning improvements - #2492
Conversation
… to the "Line ignored" message
…EF tag to the test data
|
@ghcaveman
|
|
@emyoulation Interesting concept, but what I am after should not affect this portion of the GEDCOM importer at all. Are you looking for help resolving this issue? Is there an issue which describes this? I don't mind looking into this as a separate issue. |
|
True. But you asked elsewhere if there were any comparison tools. These import flaws will interfere with the accuracy of what analysis/comparison tools exist. (Which are mostly for XML camparison/ harmonization.) And they will frustrate the efforts of contributors attempt to enhance such tools. |
The test_imp_sample_ged test compares the import diff against the data/tests/imp_sample.difs allowed-exception file. This file was present locally but never committed, so CI could not find it and the test failed. Add it so the pipeline passes.
|
Ah, I see. I was confused because the comparison tool comment was on a different thread. As it stands, this PR does not do any data modifications in the slightest. |
Added a bit more debug to the log output when importing gedcom files. Also improved the unit tests so the log output can be captured and tested.