Handle code-based OIDC token exchange - #1336
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the OIDC completion flow in the frontend to support a newer “authorization-code-in-fragment + frontend token exchange” mechanism while remaining compatible with older backend behavior.
Changes:
- Prevents the
/oidc/completetoken exchange from running twice in the same page lifecycle. - Extracts an authorization
codefrom the URL fragment, removes it from the address bar, and exchanges it viaPOST /api/oidc/tokens/. - Preserves backward compatibility by falling back to the legacy cookie-based
GET /api/oidc/tokens/when no code is present.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the backward compatible frontend change corresponding to gramps-project/gramps-web-api#928.