Repository navigation
Add setup-docker action - #232
Merged
Merged
Conversation
donat
force-pushed
the
donat/add-docker-support
branch
from
October 1, 2026 09:01
8f7cef6 to
83c15db
Compare
donat
marked this pull request as ready for review
October 1, 2026 09:14
Publishes a Build Scan for every container image built in a job, by running the Develocity Docker build agent alongside the build. The agent subscribes to BuildKit's build history stream, so nothing about the build itself changes: no Dockerfile edit, no wrapper script, no change to the command that builds the image. A consumer adds one step before their build. The agent is stopped and the scans it published are reported when the job ends. The access key goes through the shared auth helper, so Docker scans get short-lived tokens like the Maven and npm actions do. The agent needs a JDK 21, and the action deliberately avoids actions/setup-java, which exports JAVA_HOME and prepends PATH for the whole job and so changes the JDK the build under test compiles with. It probes the runner instead and only downloads a JDK when it finds none.
donat
force-pushed
the
donat/add-docker-support
branch
from
October 1, 2026 11:30
83c15db to
0db40ef
Compare
jprinet
requested changes
Oct 2, 2026
jprinet
left a comment
Member
There was a problem hiding this comment.
Three items to fix before merge, see inline comments.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes a Build Scan for every container image built in a job, by running the Develocity Docker build agent alongside the build. The agent subscribes to BuildKit's build history stream, so nothing about the build itself changes: no Dockerfile edit, no wrapper script, no change to the command that builds the image.
A consumer adds one step before their build. The agent is stopped and the scans it published are reported when the job ends. The access key goes through the shared auth helper, so Docker scans get short-lived tokens like the Maven and npm actions do.
The agent needs a JDK 21, and the action deliberately avoids actions/setup-java, which exports JAVA_HOME and prepends PATH for the whole job and so changes the JDK the build under test compiles with. It probes the runner instead and only downloads a JDK when it finds none.