Improve code reusability across MCP service files - #2
Closed
dusskapark wants to merge 1 commit into
Closed
Conversation
This commit introduces utility classes to reduce code duplication and improve maintainability across Figma MCP service files. ## Changes Summary ### New Utilities Created 1. **ToolRegistrationHelper.kt** - Reduces boilerplate in tool registration - Provides automatic error handling wrapper - Simplifies common tool patterns 2. **SchemaBuilders.kt** - Reusable schema builders for common properties - Eliminates repetitive JSON schema definitions - Provides builders for: nodeId, x, y, width, height, colors, etc. 3. **ColorUtils.kt** - Centralizes color parsing logic - Provides RGBA object parsing and formatting - Includes default color utilities 4. **ParameterExtractors.kt** - Extension functions for parameter extraction - Type-safe required/optional parameter handling - Helper functions for building parameter maps ### Refactored Files **StyleService.kt** - Original: 229 lines - Refactored: 143 lines - Reduction: 86 lines (-38%) Method-level improvements: - registerSetFillColor: 63 lines → 27 lines (-57%) - registerSetStrokeColor: 76 lines → 30 lines (-61%) - registerSetCornerRadius: 58 lines → 36 lines (-38%) ### Documentation Added comprehensive README.md with: - Usage examples and migration guide - Before/after comparisons - API documentation for all utilities ## Impact These utilities can be applied to all service files in the codebase: - Estimated 20-30 tool registration methods across services - Expected total reduction: ~500-700 lines of code - Improved consistency and maintainability - Easier to add new tools with less boilerplate ## Next Steps Other services (TextService, ComponentService, LayoutService, CreationService) can be refactored to use these utilities in future updates.
dusskapark
deleted the
claude/improve-code-reusability-01FTxN3ovH4GYNhjvVdKg5Dj
branch
December 8, 2025 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces utility classes to reduce code duplication and
improve maintainability across Figma MCP service files.
Changes Summary
New Utilities Created
ToolRegistrationHelper.kt
SchemaBuilders.kt
ColorUtils.kt
ParameterExtractors.kt
Refactored Files
StyleService.kt
Method-level improvements:
Documentation
Added comprehensive README.md with:
Impact
These utilities can be applied to all service files in the codebase:
Next Steps
Other services (TextService, ComponentService, LayoutService, CreationService)
can be refactored to use these utilities in future updates.