Fix Mandrel latest version resolution returning wrong Java version#212
Fix Mandrel latest version resolution returning wrong Java version#212gastaldi wants to merge 1 commit intograalvm:mainfrom
Conversation
The Disco API's `jdk_version` parameter matches Mandrel's distribution
version (e.g. 21.x), not the Java version in the build. When Mandrel
21.3.6.0-Final was released, it became the latest for jdk_version=21,
but it's actually a Java 17 build (mandrel-java17-21.3.6.0-Final).
Replace the jdk_version-based API query with a broader query using
latest=available, then filter results client-side by matching the
filename prefix (mandrel-java${javaVersion}-) to ensure the correct
Java version is selected.
Update test expectations to use Java versions available across platforms
and remove fragile pinned version assertions.
Fixes #211
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
turing85
left a comment
turing85
left a comment
There was a problem hiding this comment.
This seems to fix the issue: https://github.com/quarkiverse/quarkus-artemis/actions/runs/23567925092
|
@fniephaus thanks, I did sign, but it still says "Under Review" |
|
@gastaldi Great, thanks. Review shouldn't take too long and then the bot should unblock the PR. |
|
@fniephaus @gastaldi is an IBM employee and should be already covered by OCA IIRC |
|
This looks more like a DISCO API issue, looking into it. |
|
Ok, so the issue seems to be that @gastaldi used his personal email. Could you please update the commit to use your work email? |
+1, although I don't think we should merge this PR. I created the upstream PR foojayio/discoapi#149 |
zakkak
left a comment
zakkak
left a comment
There was a problem hiding this comment.
This is not the right fix. The issue seems to be on the DISCO API side.
|
Ok, I'll close it for now then and hope the DISCO API gets fixed. Thanks! |
|
Thank you @gastaldi |
4 participants
The Disco API's
jdk_versionparameter matches Mandrel's distribution version (e.g. 21.x), not the Java version in the build. When Mandrel 21.3.6.0-Final was released, it became the latest for jdk_version=21, but it's actually a Java 17 build (mandrel-java17-21.3.6.0-Final).Replace the jdk_version-based API query with a broader query using latest=available, then filter results client-side by matching the filename prefix (mandrel-java${javaVersion}-) to ensure the correct Java version is selected.
Update test expectations to use Java versions available across platforms and remove fragile pinned version assertions.