Skip to content

chore: [guardian] add expiration date filters #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anjali9791 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: [guardian] add expiration date filters #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gotocompany/guardian/v1beta1/guardian.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,8 @@ message ListUserApprovalsRequest {
bool summary_labels = 61;
// If true, includes label summaries using faceted search: for each label key, available values are computed by applying all other active label filters except that key. Mutually exclusive with summary_labels.
bool summary_labels_v2 = 62;
optional google.protobuf.Timestamp expiration_start_time = 63;
optional google.protobuf.Timestamp expiration_end_time = 64;
}

message ListUserApprovalsResponse {
Expand Down Expand Up @@ -999,6 +1001,8 @@ message ListApprovalsRequest {
bool summary_labels = 61;
// If true, includes label summaries using faceted search: for each label key, available values are computed by applying all other active label filters except that key. Mutually exclusive with summary_labels.
bool summary_labels_v2 = 62;
optional google.protobuf.Timestamp expiration_start_time = 63;
optional google.protobuf.Timestamp expiration_end_time = 64;
}

message ListApprovalsResponse {
Expand Down Expand Up @@ -1584,6 +1588,7 @@ message Approval {
bool allow_failed = 15;
bool dont_allow_self_approval = 16;
google.protobuf.Struct details = 17;
optional google.protobuf.Timestamp expiration_date = 18;
}

message AppealComment {
Expand Down
Loading