feat(entropy): add KAFKA to firehose SINK_TYPE schema and validation#164
Open
sumitaich1998 wants to merge 1 commit into
Open
feat(entropy): add KAFKA to firehose SINK_TYPE schema and validation#164sumitaich1998 wants to merge 1 commit into
sumitaich1998 wants to merge 1 commit into
Conversation
Adds "KAFKA" to the SINK_TYPE enum in the firehose JSON schema so entropy accepts firehose resources with SINK_TYPE=KAFKA. Adds SINK_KAFKA_* constants and validateKafkaSinkEnvVars which is called from readConfig when SINK_TYPE=KAFKA to fail-fast if required env vars (BROKERS, TOPIC, PROTO_MESSAGE, PROTO_KEY, PROTO_MAPPING) are absent. SINK_KAFKA_BROKERS is expected to be resolved upstream (dex/odin) from SINK_KAFKA_STREAM before the request reaches entropy; entropy only validates that it is present. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "KAFKA" to the SINK_TYPE enum in the firehose JSON schema so entropy accepts firehose resources with SINK_TYPE=KAFKA.
Adds SINK_KAFKA_* constants and validateKafkaSinkEnvVars which is called from readConfig when SINK_TYPE=KAFKA to fail-fast if required env vars (BROKERS, TOPIC, PROTO_MESSAGE, PROTO_KEY, PROTO_MAPPING) are absent.
SINK_KAFKA_BROKERS is expected to be resolved upstream (dex/odin) from SINK_KAFKA_STREAM before the request reaches entropy; entropy only validates that it is present.