Repository navigation
Conversation
43890be increased the go directive to 1.26.0, which made go mod tidy remove the `toolchain go1.26.0` line. This caused the Makefile to resolve the build image to `gotify/build:null-x`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
+ Coverage 76.09% 76.12% +0.02%
==========================================
Files 67 67
Lines 3619 3619
==========================================
+ Hits 2754 2755 +1
+ Misses 654 653 -1
Partials 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
43890be increased the go directive to 1.26.0, which made go mod tidy remove the
toolchain go1.26.0line. This caused the Makefile to resolve the build image togotify/build:null-x.This was added in #780 but I don't think it can work correctly with the problem that
go mod tidywill remove the toolchain if it's equal to the go version. And then it won't be readded again.