goroot: reduce xfail backlog across go1.24-go1.26#1773
Open
cpunion wants to merge 91 commits intogoplus:feat/go126-source-patch-cifrom
Open
goroot: reduce xfail backlog across go1.24-go1.26#1773cpunion wants to merge 91 commits intogoplus:feat/go126-source-patch-cifrom
cpunion wants to merge 91 commits intogoplus:feat/go126-source-patch-cifrom
Conversation
52d5a6e to
8aa1361
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/go126-source-patch-ci #1773 +/- ##
==============================================================
- Coverage 93.16% 92.19% -0.98%
==============================================================
Files 48 49 +1
Lines 13616 13745 +129
==============================================================
- Hits 12686 12672 -14
- Misses 742 871 +129
- Partials 188 202 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 17ff530.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the goroot xfail cleanup on top of
#1759.It keeps the current scope limited to:
1.24~1.26ubuntu+macosdebug/trace/finalizer/livenessIncluded
darwin/arm64andlinux/amd64test/gorootrunner support for an opt-in-directive-mode=runlikepath covering additional run-like directives without changing the default CI scope yetCurrent XFail Inventory
Current
test/goroot/xfail.yamlinventory in this branch:409xfails18host skips4timeout overrides431total entriesCurrent Runner Scope
test/gorootnow has three discovery modes:legacyci(current CI behavior)runlike(broader local/experimental expansion)All modes use the same default directories:
.,ken,chan,interface,internal/runtime/sys,syntax,dwarf,fixedbugs,codegen,abi,typeparam,typeparam/mdempsky,arenasbuild.Context.MatchFilelegacymodelegacyis the original narrow subset:runBare
// runcounts:linux/amd64: Go1.24.11=975, Go1.25.0=983, Go1.26.0=996linux/arm64: Go1.24.11=973, Go1.25.0=981, Go1.26.0=994darwin/arm64: Go1.24.11=972, Go1.25.0=980, Go1.26.0=993cimodeciis the current PR's widened CI surface:runrun <args>runoutputrundirrunindirbuildrunCurrent run-family counts with
-directive-mode=ci:linux/amd64: Go1.24.11=1141, Go1.25.0=1149, Go1.26.0=1162linux/arm64: Go1.24.11=1139, Go1.25.0=1147, Go1.26.0=1159darwin/arm64: Go1.24.11=1138, Go1.25.0=1146, Go1.26.0=1158runlikemoderunlikeremains available for broader local expansion and additionally includes:buildrundirCurrent run-like counts with
-directive-mode=runlike:linux/amd64: Go1.24.11=1145, Go1.25.0=1153, Go1.26.0=1166linux/arm64: Go1.24.11=1141, Go1.25.0=1149, Go1.26.0=1161darwin/arm64: Go1.24.11=1140, Go1.25.0=1148, Go1.26.0=1160Remaining mixed
errorcheckandrundircases are still counted separately because they need an errorcheck-aware harness rather than a pure run/output comparator:linux/amd64:5on Go1.24.11/1.25.0/1.26.0linux/arm64:5on Go1.24.11/1.25.0/1.26.0darwin/arm64:5on Go1.24.11/1.25.0/1.26.0Intentionally Excluded For Now
debugtracefinalizerlivenesserrorcheckandrundirin the runner mode used by CI (needs an errorcheck-compatible execution path)buildrundirin CI mode for nowKnown
buildrundirblockers found during local expansion:retjmp.go: translated asm return-jump semantics still diverge (panic: f2 not called)asmhdr.go:plan9asmconstant expansion still rejects string consts (panic: "test" not an Int)Validation
Each stale-xfail removal in this branch was rechecked on both:
darwin/arm64linux/amd64Recent regression fix additionally verified with:
LLGO_BUILD_CACHE=0 go run ./cmd/llgo test ./test/std/archive/tar./dev/docker.sh amd64 ... ./dev/llgo.sh test -timeout=20m github.com/goplus/llgo/test/std/archive/tarCurrent runner expansion verified locally with:
go test ./internal/build -count=1go test ./test/goroot -count=1/Users/lijie/sdk/go1.26.0/bin/go test ./test/goroot -run '^TestGoRootRunCases$' -count=1 -timeout 60m -args -goroot /Users/lijie/sdk/go1.26.0 -go /Users/lijie/sdk/go1.26.0/bin/go -directive-mode ci -case '^(args\.go|strength\.go|alias3\.go|fixedbugs/issue29612\.go|fixedbugs/issue46234\.go)$'go test ./internal/build -run 'TestPkgSFiles(QueryForTempDirPackage|ListsAsmForTempDirPackage)|TestPlan9Asm' -count=1Known follow-up from the broader local
runlikepath:buildrundiris not yet safe to enable in CI because of the two blockers above.