build: extend source patch branch to go1.26 CI coverage#1759
build: extend source patch branch to go1.26 CI coverage#1759cpunion wants to merge 33 commits intogoplus:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements a source patching system to facilitate compatibility with Go 1.26, allowing the build process to skip or override standard library declarations using AST-based filtering and specialized directives. It introduces several compatibility shims for runtime features like sync.HashTrieMap, iter, and reflect, while updating the build logic to handle these overlays. Feedback was provided regarding the fragility of using copy with bytes.Replace during directive sanitization, suggesting a more robust byte-level manipulation to avoid issues if replacement lengths differ.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
========================================
Coverage 93.16% 93.16%
========================================
Files 48 48
Lines 13349 13616 +267
========================================
+ Hits 12437 12686 +249
- Misses 726 742 +16
- Partials 186 188 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cb28d71 to
cf2542c
Compare
cf2542c to
41fa6d3
Compare
41fa6d3 to
08b82d8
Compare
5105c0e to
4568f16
Compare
4568f16 to
c05ff53
Compare
c05ff53 to
6b1e842
Compare
Summary
LLGoworkflow coverage togo1.26.0internal/syncas the main go1.26 source patchNotes
feat/source-patch-protoand therefore currently includes the source-patch prototype changes from build: prototype source patches for stdlib compat #1758