Skip to content

build: extend source patch branch to go1.26 CI coverage#1759

Draft
cpunion wants to merge 33 commits intogoplus:mainfrom
cpunion:feat/go126-source-patch-ci
Draft

build: extend source patch branch to go1.26 CI coverage#1759
cpunion wants to merge 33 commits intogoplus:mainfrom
cpunion:feat/go126-source-patch-ci

Conversation

@cpunion
Copy link
Copy Markdown
Collaborator

@cpunion cpunion commented Mar 28, 2026

Summary

  • extend LLGo workflow coverage to go1.26.0
  • keep source patch usage narrow and add internal/sync as the main go1.26 source patch
  • add the minimal go1.26 runtime/reflect/crypto compat needed to boot hello and initial stdlib tests

Notes

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a source patching system to facilitate compatibility with Go 1.26, allowing the build process to skip or override standard library declarations using AST-based filtering and specialized directives. It introduces several compatibility shims for runtime features like sync.HashTrieMap, iter, and reflect, while updating the build logic to handle these overlays. Feedback was provided regarding the fragility of using copy with bytes.Replace during directive sanitization, suggesting a more robust byte-level manipulation to avoid issues if replacement lengths differ.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 55.26316% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.16%. Comparing base (2075aa9) to head (6b1e842).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
internal/plan9asm/translate.go 0.00% 9 Missing and 1 partial ⚠️
internal/env/env.go 62.50% 5 Missing and 1 partial ⚠️
cl/instr.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1759    +/-   ##
========================================
  Coverage   93.16%   93.16%            
========================================
  Files          48       48            
  Lines       13349    13616   +267     
========================================
+ Hits        12437    12686   +249     
- Misses        726      742    +16     
- Partials      186      188     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cpunion cpunion force-pushed the feat/go126-source-patch-ci branch from cb28d71 to cf2542c Compare March 28, 2026 12:50
@cpunion cpunion force-pushed the feat/go126-source-patch-ci branch from cf2542c to 41fa6d3 Compare March 28, 2026 13:58
@cpunion cpunion force-pushed the feat/go126-source-patch-ci branch from 41fa6d3 to 08b82d8 Compare March 28, 2026 14:30
@cpunion cpunion force-pushed the feat/go126-source-patch-ci branch from 5105c0e to 4568f16 Compare March 29, 2026 04:17
@cpunion cpunion force-pushed the feat/go126-source-patch-ci branch from 4568f16 to c05ff53 Compare March 29, 2026 05:08
@cpunion cpunion force-pushed the feat/go126-source-patch-ci branch from c05ff53 to 6b1e842 Compare March 31, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant