test(embed): unignore verified esp32c3-basic cases#1741
test(embed): unignore verified esp32c3-basic cases#1741luoliwoshang wants to merge 1 commit intogoplus:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the test suite for embedded systems by updating the ignore list for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| "./_testrt/tpfunc", // unexpected output: type size mismatch (got 8 4 4, expected 16 8 8) | ||
| "./_testrt/typalias", // fast fail: build constraints exclude all Go files | ||
| }, | ||
| "./_testdata": {}, |
There was a problem hiding this comment.
Since the list of ignored tests for ./_testdata is now empty, this map entry can be removed for better readability. The test runner correctly handles a missing key by treating it as an empty list of ignored tests.
|
Clean, well-executed maintenance PR. The counts in the description are accurate (18 removed, 21 remaining), entries stay alphabetically sorted, and inline comments documenting failure reasons are consistent and descriptive. No security or performance concerns — the validated 524s runtime is well within the 30m timeout. One minor style nit below. |
![xgopilot[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| "./_testrt/tpfunc", // unexpected output: type size mismatch (got 8 4 4, expected 16 8 8) | ||
| "./_testrt/typalias", // fast fail: build constraints exclude all Go files | ||
| }, | ||
| "./_testdata": {}, |
There was a problem hiding this comment.
Nit: Now that all _testdata tests pass, you could remove this key from the map entirely instead of keeping an empty slice. That would make it immediately obvious there are no ignores for this directory, rather than looking like a placeholder. Totally optional though — the current form is valid Go.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 48 48
Lines 13352 13352
=======================================
Hits 12438 12438
Misses 727 727
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary
esp32c3-basicincl/compile_test.goesp32target ignore list unchangedValidation
LLGO_EMBED_TESTS=1 go test ./cl -run 'TestRunEmbedEmulator/esp32c3-basic' -count=1 -timeout 30m -vok github.com/goplus/llgo/cl 524.038s)