Skip to content

New design demo#3010

Draft
nighca wants to merge 10 commits intogoplus:devfrom
nighca:new-design-demo
Draft

New design demo#3010
nighca wants to merge 10 commits intogoplus:devfrom
nighca:new-design-demo

Conversation

@nighca
Copy link
Copy Markdown
Collaborator

@nighca nighca commented Apr 3, 2026

Demo for new design. DO NOT MERGE.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on migrating the project's styling system to Tailwind CSS, which involves updating configuration files, removing legacy SCSS files, and refactoring various components to use Tailwind utility classes. Additionally, some UI components were updated for better consistency. I have identified a potential issue in UIButtonGroupItem.vue where the secondary variant now shares identical styling with the primary variant, which may be unintentional.

Comment on lines +56 to 62
background-color: var(--ui-color-grey-400);
color: var(--ui-color-grey-1000);
&.active {
background-color: var(--ui-color-grey-200);
color: var(--ui-color-turquoise-600);
background-color: var(--ui-color-grey-100);
color: var(--ui-color-grey-1000);
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The secondary variant now has the same styles as the primary variant. This might be unintentional. If the goal is to have them look the same, consider removing the secondary variant to simplify the component's API. If they should be different, the previous styles for secondary should be restored or new distinct styles should be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants