Skip to content

Update builder-component.lib.pen #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiaxin-915 wants to merge 2 commits into
base: ui
Choose a base branch
from
Open

Update builder-component.lib.pen #3005

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
450aa53
Update builder-component.lib.pen
jiaxin-915 Apr 2, 2026
5b6ac3f
Update optimize-sprite-quick-config.html
jiaxin-915 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions ui/components/spx/builder-component.lib.pen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "2.9",
"version": "2.10",
"children": [
{
"type": "frame",
Expand Down Expand Up @@ -260,7 +260,7 @@
"type": "frame",
"id": "wH3BG",
"name": "container",
"fill": "$turquoise500",
"fill": "#e7f9faff",
Copy link
Copy Markdown
Contributor

@xgopilot xgopilot bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fill for this container was changed from the semantic design token $turquoise500 to a hardcoded hex value #e7f9faff. The rest of the file consistently uses $turquoise500 (and other $-prefixed tokens) throughout. Hardcoding the hex here means:

  • This element won't update if $turquoise500 is ever changed globally.
  • #e7f9faff is a light tint, visually distinct from $turquoise500 (#0bc0cf) — this appears to be an intentional color deviation, but it should be represented as a proper design token (e.g. $turquoise100) rather than a raw hex.

Please use the design token system instead of a hardcoded color.

"cornerRadius": 4,
"stroke": {
"align": "inside",
Expand Down Expand Up @@ -25870,7 +25870,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.05592341929603606,
"y": -0.055923419296032506,
"descendants": {
Copy link
Copy Markdown
Contributor

@xgopilot xgopilot bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These floating-point changes (e.g. -0.05592341929603606 → -0.055923419296032506) appear to be re-serialization noise from the design tool — the values are semantically identical. There are ~25 such changes throughout this diff, making it difficult to identify the one intentional change (the color on line 263).

Consider configuring the design tool to export with stable decimal precision, or adding a normalization pre-commit hook for .pen files to avoid this churn accumulating in git history.

"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -26128,7 +26128,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.05592341929603606,
"y": -0.055923419296032506,
"descendants": {
"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -26386,7 +26386,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.05592341929603606,
"y": -0.055923419296032506,
"descendants": {
"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -26644,7 +26644,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.05592341929603606,
"y": -0.055923419296032506,
"descendants": {
"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -34541,7 +34541,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.05592341929603606,
"y": -0.055923419296032506,
"descendants": {
"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -34923,7 +34923,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.05592341929603606,
"y": -0.055923419296032506,
"descendants": {
"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -35231,7 +35231,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.05592341929603606,
"y": -0.055923419296032506,
"descendants": {
"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -36765,7 +36765,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 0,
"y": -0.06421186883602203,
"y": -0.06421186883602559,
"descendants": {
"u4Nmq": {
"width": "fit_content",
Expand Down Expand Up @@ -95776,7 +95776,7 @@
"x": 7.5
},
"X8IR3": {
"x": 7.526880183115942
"x": 7.52688018311594
},
"ApUr2": {
"y": 26.05364021103985
Expand Down Expand Up @@ -96773,7 +96773,7 @@
"x": 7.504752022570152
},
"X8IR3": {
"x": 7.531632205686094
"x": 7.531632205686092
},
"ApUr2": {
"x": 0,
Expand Down Expand Up @@ -99719,7 +99719,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 16,
"y": 3.966045550353831
"y": 3.966045550353832
},
"eD6dL": {
"y": 0.06796616471260078
Expand Down Expand Up @@ -100894,8 +100894,8 @@
"y": 721.7793307798149
},
"tYlkx": {
"x": 51.9852972911389,
"y": 14.014729779865018
"x": 51.985297291138906,
"y": 14.01472977986502
}
}
},
Expand Down Expand Up @@ -101133,8 +101133,8 @@
"y": 721.7793307798149
},
"tYlkx": {
"x": 51.9852972911389,
"y": 14.014729779865018
"x": 51.985297291138906,
"y": 14.01472977986502
}
}
},
Expand Down Expand Up @@ -101807,7 +101807,7 @@
"width": "fit_content",
"height": "fit_content",
"x": 16,
"y": 3.966045550353831
"y": 3.966045550353832
},
"eD6dL": {
"y": 0.06796616471260078
Expand Down Expand Up @@ -103015,8 +103015,8 @@
"y": 721.7793307798149
},
"iWdnn": {
"x": 51.9852972911389,
"y": 14.014729779865018
"x": 51.985297291138906,
"y": 14.01472977986502
}
}
},
Expand Down Expand Up @@ -104369,8 +104369,8 @@
"y": 721.7793307798149
},
"wq9rI": {
"x": 51.9852972911389,
"y": 14.014729779865018
"x": 51.985297291138906,
"y": 14.01472977986502
}
}
},
Expand Down Expand Up @@ -105051,8 +105051,8 @@
"y": 721.7793307798149
},
"npqJj": {
"x": 51.9852972911389,
"y": 14.014729779865018
"x": 51.985297291138906,
"y": 14.01472977986502
}
}
},
Expand All @@ -105075,7 +105075,7 @@
},
"YYiGG": {
"x": 86.04793682368762,
"y": 4.085283405194483
"y": 4.085283405194484
},
"bKO2T": {
"height": "fill_container",
Expand Down Expand Up @@ -117929,4 +117929,4 @@
"url": "../../images/xbuilder-icons-02.ttf"
}
]
}
}
Copy link
Copy Markdown
Contributor

@xgopilot xgopilot bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing newline was removed. POSIX text files should end with a newline, and many diff/lint tools will flag its absence. Please restore it.