Skip to content

feat(lsp): add xgoGetProperties command for lsp #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
go-wyvern wants to merge 2 commits into
base: dev
Choose a base branch
from
+33 −1
Open

feat(lsp): add xgoGetProperties command for lsp #2837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f6ccf3
feat(lsp): add xgoGetProperties command for lsp
go-wyvern Feb 11, 2026
fcaa622
change workspaceExecuteCommandXGoGetProperty to workspaceExecuteComma…
go-wyvern Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion spx-gui/src/components/editor/code-editor/lsp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
} from '../common'
import { XGoLanguageClient, type IConnection, ResponseError } from './spxls/client'
import type { Files as SpxlsFiles, RequestMessage, ResponseMessage, NotificationMessage } from './spxls'
import { xgoGetInputSlots, xgoRenameResources } from './spxls/commands'
import { xgoGetInputSlots, xgoGetProperties, xgoRenameResources } from './spxls/commands'
import {
type CompletionItem,
isDocumentLinkForResourceReference,
Expand Down Expand Up @@ -254,6 +254,17 @@ export class SpxLSPClient extends Disposable {
)
}

async workspaceExecuteCommandXGoGetProperties(
ctx: RequestContext,
...params: xgoGetProperties.Arguments
): Promise<xgoGetProperties.Result> {
return this.executeCommand<xgoGetProperties.Arguments, xgoGetProperties.Result>(
ctx,
xgoGetProperties.command,
...params
)
}

async textDocumentDocumentLink(
ctx: RequestContext,
params: lsp.DocumentLinkParams
Copy link
Copy Markdown
Contributor

@xgopilot xgopilot bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Convenience Method: Consider adding a higher-level getProperties wrapper method following the established pattern in this codebase.

Existing patterns:

  • getInputSlots (line 428) wraps workspaceExecuteCommandXGoGetInputSlots
  • getCompletionItems (line 421) wraps textDocumentCompletion
  • getResourceReferences (line 389) wraps textDocumentDocumentLink

Suggested implementation:

async getProperties(ctx: RequestContext, target: string): Promise<xgoGetProperties.XGoProperty[]> {
  const result = await this.workspaceExecuteCommandXGoGetProperties(ctx, { target })
  if (result == null) return []
  return result
}

This would provide a cleaner API and improve maintainability.

Expand Down
21 changes: 21 additions & 0 deletions spx-gui/src/components/editor/code-editor/lsp/spxls/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,24 @@ export namespace xgoGetInputSlots {
}
export type Result = XGoInputSlot[] | null
}

export namespace xgoGetProperties {
export const command = 'xgo.getProperties'
type XGoGetPropertiesParams = {
/** The target name, for example `Game` or a specific sprite name. */
target: string
}
export type Arguments = [XGoGetPropertiesParams]
/** A property of a target type. */
export type XGoProperty = {
/** The property name. */
name: string
/** The property type as a string. */
type: string
/** The kind of property. */
kind: 'field' | 'method'
/** Optional documentation for the property. */
doc?: string
}
export type Result = XGoProperty[]
}