diff3proof: add waterfall, glyphset and spacing/kerning proofs - #34
Open
emmamarichal wants to merge 5 commits into
Open
diff3proof: add waterfall, glyphset and spacing/kerning proofs#34emmamarichal wants to merge 5 commits into
emmamarichal wants to merge 5 commits into
Conversation
Extend SampleMode with Waterfall, Glyphs and Spacing variants, make --sample-mode repeatable (comma-separated), and add --waterfall-sizes.
Independent, non-exclusive template blocks so several proof types can appear on the same page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@simoncozens @m4rc1e
Summary
diff3proofcurrently only generates one proof type: paragraphs of sample text (--sample-mode context) or a codepoint-coverage pangram (--sample-mode cover). This PR adds three more proof types that existed in the old diffenator2/gftools pipeline but have no equivalent in diffenator3 today — including for the "onboarding" case (a single font, no "before" version to diff against):waterfall— the coverage pangram rendered at a ladder of point sizes (customizable via--waterfall-sizes), to spot hinting/ rasterization jumps.glyphs— every encoded glyph in the font, laid out in a grid.spacing— curated strings (ported from diffenator2'sGF_Latin_CoreSpacing/Kerning wordlists) that stress sidebearing consistency and kerning pairs. Latin-only for now; other scripts can follow the same pattern.Design
--sample-modeis now repeatable (comma-separated), and all requested sections render into the same self-contained HTML file rather than one file per proof type:The default (
--sample-modeomitted) is unchanged — same singlecontextoutput as before.Testing
--waterfall-sizesoverride#fonttoggle) correctly flips all three new sections along with the existing ones, since they reuse the same.font-before/.font-afterCSS classes--sample-modeflag) verified byte-for-byte identical tomaincargo fmt --all -- --checkandcargo clippy --all-targets --all-features -- -D warningsboth cleanOpen questions
--sample-modebe renamed (e.g.--proofs) now that it no longer only selects a sample of text, or kept as-is for compatibility with existinggftools qainvocations?Images