Skip to content

chore(bqjdbc): switch connection identifier to UUID #12957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keshavdandeva wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(bqjdbc): switch connection identifier to UUID #12957

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbd607d
chore(bqjdbc): switch connection identifier to UUID
keshavdandeva Apr 29, 2026
5bab5b1
chore: add timstamp to connection id
keshavdandeva Apr 30, 2026
ad0e558
chore: refactor log file name and tests
keshavdandeva Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...gle-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcMdc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,15 @@

package com.google.cloud.bigquery.jdbc;

import java.util.UUID;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicLong;

/**
* Lightweight MDC implementation for the BigQuery JDBC driver using InheritableThreadLocal.
* Allocates a dedicated, independent InheritableThreadLocal object per concrete BigQueryConnection
* instance.
*/
class BigQueryJdbcMdc {
Comment thread
keshavdandeva marked this conversation as resolved.
private static final AtomicLong nextId = new AtomicLong(1);
private static final ConcurrentHashMap<BigQueryConnection, InheritableThreadLocal<String>>
instanceLocals = new ConcurrentHashMap<>();
private static final ConcurrentHashMap<BigQueryConnection, String> instanceIds =
Expand All @@ -41,8 +40,7 @@ static MdcCloseable registerInstance(BigQueryConnection connection, String id) {
instanceIds.computeIfAbsent(
connection,
k -> {
String suffix =
(id != null && !id.isEmpty()) ? id : String.valueOf(nextId.getAndIncrement());
String suffix = (id != null && !id.isEmpty()) ? id : UUID.randomUUID().toString();
return "JdbcConnection-" + suffix;
});

Expand Down
Loading