chore(os-login): rm unused config API path#12858
Merged
Conversation
Contributor
Author
|
hmm, this config change did not trigger hermetic build: Forcing it to run with temp change to script |
|
|
This reverts commit 678ba7d.
Contributor
Author
|
After forcing generate on this library, now hermetic build workflow correctly triggers generate and completes with no code change: full log: https://github.com/googleapis/google-cloud-java/actions/runs/24739089474/job/72373657169?pr=12858 Now proceed to revert temp change. |
blakeli0
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Removing unused API path from config for os-login, so that it matches the generated code status.
v1beta of java-os-login was added to the generation_config.yaml as part of initial migration to hermetic build: 14b7346, but client library code for v1beta is not present in java-os-login/google-cloud-os-login dir. This is due to deep-copy-regex being too strict and does not copy /v1beta from staging dir to final output.
Expect generation workflow to run successfully with not change. (no sample code exists for os-login)
For #12736
For googleapis/librarian#5370