Skip to content

chore(os-login): rm unused config API path#12858

Merged
zhumin8 merged 3 commits intomainfrom
rm-os-login-v1beta
Apr 21, 2026
Merged

chore(os-login): rm unused config API path#12858
zhumin8 merged 3 commits intomainfrom
rm-os-login-v1beta

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented Apr 20, 2026

Removing unused API path from config for os-login, so that it matches the generated code status.

v1beta of java-os-login was added to the generation_config.yaml as part of initial migration to hermetic build: 14b7346, but client library code for v1beta is not present in java-os-login/google-cloud-os-login dir. This is due to deep-copy-regex being too strict and does not copy /v1beta from staging dir to final output.

Expect generation workflow to run successfully with not change. (no sample code exists for os-login)

For #12736
For googleapis/librarian#5370

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the v1beta proto path for the OS Login API from the generation_config.yaml file. There are no review comments to address, and I have no feedback to provide regarding this change.

@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Apr 21, 2026

hmm, this config change did not trigger hermetic build:

+ changed_libraries=
+ echo 'Changed libraries are: No changed library.'
Changed libraries are: No changed library.

Forcing it to run with temp change to script

@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Apr 21, 2026

After forcing generate on this library, now hermetic build workflow correctly triggers generate and completes with no code change:

Changed libraries are: os-login.

full log: https://github.com/googleapis/google-cloud-java/actions/runs/24739089474/job/72373657169?pr=12858

Now proceed to revert temp change.

@zhumin8 zhumin8 marked this pull request as ready for review April 21, 2026 18:55
@zhumin8 zhumin8 requested a review from a team as a code owner April 21, 2026 18:55
@zhumin8 zhumin8 requested a review from blakeli0 April 21, 2026 18:55
@zhumin8 zhumin8 enabled auto-merge (squash) April 21, 2026 18:55
@zhumin8 zhumin8 merged commit 460a1b2 into main Apr 21, 2026
110 checks passed
@zhumin8 zhumin8 deleted the rm-os-login-v1beta branch April 21, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants