Skip to content

fix(gax): reduce visibility of ApiTracerContext methods #12738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakeli0 merged 6 commits into from
Apr 10, 2026
Merged

fix(gax): reduce visibility of ApiTracerContext methods #12738

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d006fc3
feat(o11y): reduce visibility of ApiTracerContext methods
blakeli0 Apr 10, 2026
1b7e994
feat(o11y): reduce visibility of some builder methods in ApiTracerCon…
blakeli0 Apr 10, 2026
ed34065
test(o11y): fix OpenTelemetryMetricsFactoryTest and cover withContext
blakeli0 Apr 10, 2026
2091d6e
feat(o11y): add needsContext and private constructor to OpenTelemetry…
blakeli0 Apr 10, 2026
323e4b7
chore: format
blakeli0 Apr 10, 2026
ef0946e
chore: address comments.
blakeli0 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracerContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public enum Transport {
* @return the server port, or {@code null} if not set
*/
@Nullable
public abstract Integer serverPort();
abstract Integer serverPort();
Comment thread
blakeli0 marked this conversation as resolved.

/**
* Returns the library metadata associated with the RPC.
Expand Down Expand Up @@ -135,7 +135,7 @@ String rpcSystemName() {
* @return the operation type, or {@code null} if not set
*/
@Nullable
public abstract OperationType operationType();
abstract OperationType operationType();
Comment thread
blakeli0 marked this conversation as resolved.

/**
* Returns the HTTP method used for the RPC, in case the RPC is an HttpJson method.
Expand All @@ -159,11 +159,11 @@ String rpcSystemName() {

/** The service name of a client (e.g. "bigtable", "spanner"). */
@Nullable
public abstract String serviceName();
abstract String serviceName();
Comment thread
blakeli0 marked this conversation as resolved.

/** The url domain of the request (e.g. "pubsub.googleapis.com"). */
@Nullable
public abstract String urlDomain();
abstract String urlDomain();
Comment thread
blakeli0 marked this conversation as resolved.

@Nullable
protected abstract Supplier<String> destinationResourceIdSupplier();
Expand All @@ -173,7 +173,7 @@ String rpcSystemName() {
* //pubsub.googleapis.com/projects/p/locations/l/topics/t).
*/
@Nullable
public String destinationResourceId() {
String destinationResourceId() {
Comment thread
blakeli0 marked this conversation as resolved.
Supplier<String> supplier = destinationResourceIdSupplier();
if (supplier == null) {
return null;
Expand Down Expand Up @@ -209,7 +209,7 @@ <RequestT> ApiTracerContext withResourceNameExtractor(
/**
* @return a map of attributes to be included in attempt-level spans
*/
public Map<String, Object> getAttemptAttributes() {
Map<String, Object> getAttemptAttributes() {
Comment thread
blakeli0 marked this conversation as resolved.
Map<String, Object> attributes = new HashMap<>();
if (!Strings.isNullOrEmpty(serverAddress())) {
attributes.put(ObservabilityAttributes.SERVER_ADDRESS_ATTRIBUTE, serverAddress());
Expand Down Expand Up @@ -322,15 +322,15 @@ ApiTracerContext merge(ApiTracerContext other) {
return builder.build();
}

public static ApiTracerContext empty() {
static ApiTracerContext empty() {
Comment thread
blakeli0 marked this conversation as resolved.
return newBuilder().setLibraryMetadata(LibraryMetadata.empty()).build();
}

public static Builder newBuilder() {
return new AutoValue_ApiTracerContext.Builder();
}

public abstract Builder toBuilder();
abstract Builder toBuilder();
Comment thread
blakeli0 marked this conversation as resolved.

@AutoValue.Builder
public abstract static class Builder {
Expand All @@ -342,7 +342,7 @@ public abstract static class Builder {

public abstract Builder setTransport(@Nullable Transport transport);

public abstract Builder setOperationType(@Nullable OperationType operationType);
abstract Builder setOperationType(@Nullable OperationType operationType);

public abstract Builder setServerPort(@Nullable Integer serverPort);

Expand All @@ -354,7 +354,7 @@ public abstract static class Builder {

public abstract Builder setUrlDomain(@Nullable String urlDomain);

public abstract Builder setDestinationResourceIdSupplier(
abstract Builder setDestinationResourceIdSupplier(
@Nullable Supplier<String> destinationResourceIdSupplier);

public abstract ApiTracerContext build();
Expand Down
Loading